Bug 21547

Summary:	Contacts removed from roster stay on subscribe:remote-pending
Product:	Telepathy	Reporter:	Will Thompson <will>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/remove-from-rp-subscribe
Whiteboard:
i915 platform:		i915 features:

Description Will Thompson 2009-05-04 10:00:57 UTC

If I have Gabble connected at the same time as another client, and in that other client attempt to subscribe to a contact's presence, Gabble is notified, and the contact pops up on subscribe:remote-pending. But if in the other client I remove them entirely from my roster, they don't disappear from subscribe.

The linked branch fixes this bug, but there was code in place specifically to stop this working. Sadly, the commit appears to be a diff|patch to work around darcs. :(

I'd appreciate some input from people who worked on the roster in ye olden days.

Comment 1 Will Thompson 2009-05-05 05:46:40 UTC

Apparently the code in place was put there to work around a Google roster bug. I'll have to look into whether that's still applicable.

Comment 2 Simon McVittie 2009-05-06 02:37:28 UTC

Removing patch tag until GTalk interop has been investigated.

Comment 3 Will Thompson 2009-05-19 07:41:09 UTC

From what I can reconstruct from looking at discussion from when the workaround was added, in the past, a subscription request being accepted would cause GTalk to send:

* A roster update with subscription="to";
* A roster update without subscription="to" and with ask="subscribe";
* A roster update with subscription="to".

My branch does not remove the workaround for that. Adding and removing Google Talk contacts on Google Talk accounts seems to work as well with this branch as with master — modulo server bugs like #11883, which I can't see how to work around :( — so re-adding the patch keyword.

Comment 4 Will Thompson 2009-05-19 07:41:42 UTC

(That would be <http://bugs.freedesktop.org/show_bug.cgi?id=11883>.)

Comment 5 Guillaume Desmottes 2009-05-19 08:42:07 UTC

<cassidy> wjt: remove-from-rp-subscribe looks good but I'd be more confident if a XMPP guru could check the XMPP logic

add a NEWS entry too

Comment 6 Will Thompson 2009-05-21 04:21:12 UTC

I merged a prefix of this branch, but the subscribe:remote-pending patches are still pending further discussion.

Comment 7 Will Thompson 2009-05-26 04:38:51 UTC

Note that this bug actually also occurs with only one client connected: add someone to subscribe, then try to remove them, and it doesn't work.

Comment 8 Will Thompson 2009-05-26 04:54:01 UTC

Merged, will be in 0.7.28.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.