Bug 19564

Ah. Nother one that always confuses me:

The "Review" button when updates are available.

Review can mean a lot of things. E.g. "Look through a list of issues" (like in this case), but also "Double-check for correctness by being the second person taking a look" (reviewing patches, you know). The German translation of that button is... bad. Translator comment might help here...

(In reply to comment #0)
> #: ../data/gpk-client.glade.h:1
> msgid " "
> 
> Do not mark empty strings for translation.
> Just remove the "translatable=yes".

Done.

> #. TRANSLATORS: title: how many packages require this package
> #: ../src/gpk-application.c:710
> #, c-format
> msgid "%i additional package require %s"
> msgid_plural "%i additional packages require %s"
> 
> First one is not a proper english sentence. Should be
> msgid "%i additional package requires %s".

I've reworked this string.

> #. TRANSLATORS: if the menu won't fit, inform the user there are a few more
> things waiting
> #: ../src/gpk-watch.c:135
> #, c-format
> msgid "(%i more tasks)"
> Does not work in Czech or Slovak. Please use proper ngettext support:
> http://live.gnome.org/TranslationProject/DevGuidelines/Plurals

Done.

> #. TRANSLATORS: message: show the list of packages for this package
> #: ../src/gpk-application.c:792
> #, c-format
> msgid "Packages listed below are required for %s to function correctly."
> msgid_plural "Packages listed below are required for %s to function correctly."
> 
> First one should be "Package" instead of "Packages" probably?

I think I've clarified this one.

> #. TRANSLATORS: generic confirm, use the application name if we can
> #: ../src/gpk-client.c:1668
> #, fuzzy
> msgid "wants to install packages"
> #. TRANSLATORS: string is an action, e.g. "wants to install a codec"
> #: ../src/gpk-client.c:1196
> #, c-format
> msgid "A program %s"
> 
> Impossible to translate correctly in languages with a different sentence
> structure.
> Never ever split sentences.
> http://live.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences

My bad. I've unsplit them, and provided about 30 more strings fo you guys to translate.

> #: ../src/gpk-dialog.c:73
> #, fuzzy
> msgid "many packages"
> msgstr "viele Pakete"
> 
> Also looks suspicious. Again splitting sentences, eh? ;-)

This is a bodge to make the GUI look right when the user selects more than 5 packages. I'll rework.

> #: ../src/gpk-enum.c:1162
> msgid "Installed packages"
> #: ../src/gpk-enum.c:1165
> msgid "Installed local files"
> #: ../src/gpk-enum.c:1159
> msgid "Removed packages"
> 
> short for "Packages have been removed" or either "List of removed packages"?
> Unfortunately this makes a big difference in german translation.
> Please add translator comments to those...
> http://live.gnome.org/TranslationProject/DevGuidelines/Use%20comments

Added.

(In reply to comment #1)
> Review can mean a lot of things. E.g. "Look through a list of issues" (like in
> this case), but also "Double-check for correctness by being the second person
> taking a look" (reviewing patches, you know). The German translation of that
> button is... bad. Translator comment might help here...

I've added a comment. If you want to change translator comments like this, feel free to check them into svn like normal, or I can arrange a proper git account on our private server. Thanks dude.