Bug 18997

Summary:

Convert libICE to ANSI C & related cleanup

Product:

xorg

Reporter:

Peter Breitenlohner <peb>

Component:

Lib/ICE

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

CC:

alan.coopersmith, pcpa

Version:

git

Keywords:

janitor, patch

Hardware:

All

OS:

All

Whiteboard:

i915 platform:

i915 features:

Bug Depends on:

18978

Bug Blocks:

Attachments:

Description	Flags
patch 1/8	none
patch 2/8	none
patch 3/8	none
patch 4/8	none
patch 5/8	none
patch 6/8	none
patch 7/8	none
patch 8/8	none
patch 1/8 updated	none

Description Peter Breitenlohner 2008-12-10 01:33:58 UTC

Created attachment 20992 [details] [review]
patch 1/8

Attached are 8 patches with the aim to convert libICE to ANSI C

1. Use XORG_CHANGELOG and XORG_CWARNFLAGS from util-macros-1.2

2. Activate CWARNFLAGS

3. Statify some functions, export _IceP[ao]MagicCookie1Proc for use in linSM

4. Convert all old-style function definitions. The split between (3 - small) and (4 - big) should simplify a review.

5. Use NULL, not zero, for pointers

6. Use memcmp instead of binaryEqual

7. Remove ChangeLog from EXTRA_DIST and CLEANFILES

8. Bump to 1.0.5

============

Alan, Paulo,

please review these patches and, if you agree, please apply them. If so, don't forget to create a branch 1.0.5 and release tarballs

Comment 1 Peter Breitenlohner 2008-12-10 01:35:35 UTC

Created attachment 20993 [details] [review]
patch 2/8

Comment 2 Peter Breitenlohner 2008-12-10 01:36:34 UTC

Created attachment 20994 [details] [review]
patch 3/8

Comment 3 Peter Breitenlohner 2008-12-10 01:37:05 UTC

Created attachment 20995 [details] [review]
patch 4/8

Comment 4 Peter Breitenlohner 2008-12-10 01:37:35 UTC

Created attachment 20996 [details] [review]
patch 5/8

Comment 5 Peter Breitenlohner 2008-12-10 01:38:49 UTC

Created attachment 20997 [details] [review]
patch 6/8

Comment 6 Peter Breitenlohner 2008-12-10 01:39:25 UTC

Created attachment 20998 [details] [review]
patch 7/8

Comment 7 Peter Breitenlohner 2008-12-10 01:39:55 UTC

Created attachment 20999 [details] [review]
patch 8/8

Comment 8 Peter Breitenlohner 2008-12-10 02:52:15 UTC

Using XORG_CWARNFLAGS from the util-macros-1.2.0 (release) fails for gcc-3.3.x and earlier. This has been fixed by recent util-macros git commits. Does this imply that a new release 1.2.1 is required and the first patch should require that newer version??

Comment 9 Peter Breitenlohner 2008-12-17 00:19:16 UTC

Created attachment 21230 [details] [review]
patch 1/8 updated

Comment 10 Paulo César Pereira de Andrade 2009-01-06 12:12:35 UTC

  Hi Petter,

  Sorry for the delay. I just made the release of libICE 1.0.5
with all the patches applied.

  So far I think all patches you submited are of good quality,
and correct. I think you should apply for an account in
freedesktop, as apparently a "xorg janitors" list/group will
not really be formed if things stay "as is" :-)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.