Bug 15048

Summary: xorg/driver/xf86-video-chips - Compile warning fixes
Product: xorg Reporter: Paulo César Pereira de Andrade <pcpa>
Component: Driver/chipsAssignee: Egbert Eich <eich>
Status: RESOLVED NOTABUG QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium Keywords: janitor, patch
Version: git   
Hardware: Other   
OS: All   
i915 platform: i915 features:
Description Flags
0001-Compile-warning-fixes.patch none

Description Paulo César Pereira de Andrade 2008-03-15 19:57:36 UTC
Created attachment 15168 [details] [review]

Ansify functions in AsmMacros.h. These are used only in this driver
so there should not exist any problems, but the functions receive char/short
  Declare as static some functions from the utility programs to avoid
warning about missing prototypes.
  Include <unistd.h> for usleep prototype.
  Don't declare some unused variables, or move them to the appropriate ifdef.
Comment 1 Paulo César Pereira de Andrade 2008-07-23 11:21:58 UTC
  This patch attempted to correct some somewhat funny
code like:

static inline unsigned int foo(a, b)
  short a;
  char b;
   bar((short)a, (char)b);

declared in a header file.

  Maybe the proper patch would be to actually promote
types when doing the ansification, so that it should
be binary compatible, but should work either way.

  Anyway, it is not really a bug.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.