Bug 15036

Summary:

xorg/driver/xf86-video-sunffb - Compile warning fixes

Product:

xorg

Reporter:

Paulo César Pereira de Andrade <pcpa>

Component:

Driver/other

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED NOTABUG

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Keywords:

janitor, patch

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
0001-Compile-warning-fixes.patch	none

Description Paulo César Pereira de Andrade 2008-03-15 17:09:44 UTC

Created attachment 15156 [details] [review]
0001-Compile-warning-fixes.patch

Add prototypes to ffh.h.
  If 0 static unused functions.
  Protect definition of FFBSync() around ifdef, as there are also macro
versions (one for debug and one that is a noop), and the function definition
does nothing.

  Just because it compiles in x86 :-)

Comment 1 Paulo César Pereira de Andrade 2008-07-23 11:00:37 UTC

  It compiled correctly when adding prototypes to
a header file, and since there are no type promotions,
this is not really a bug.
  The protection of a function also defined as a
macro could be useful, but it is probably just a
debugging feature that was left in the sources.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.