Bug 14979

Summary:

xorg/driver/xf86-video-s3virge - Correct crash due to improper pointer deference

Product:

xorg

Reporter:

Paulo César Pereira de Andrade <pcpa>

Component:

Driver/s3virge

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Keywords:

patch

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
0001-Compile-warning-fixes.patch	none
0001-Compile-warning-fixes.patch	none
0001-Correct-calls-to-find_bios_string.patch	none

Description Paulo César Pereira de Andrade 2008-03-12 14:51:07 UTC

Created attachment 15073 [details] [review]
0001-Compile-warning-fixes.patch

This seens to also fix a genuine bug detected when
checking the warning about integer conversion to pointer.

Comment 1 Paulo César Pereira de Andrade 2008-04-12 17:59:07 UTC

Created attachment 15859 [details] [review]
0001-Compile-warning-fixes.patch

  Patch remade.

  Also included a change to the name of one argument of
the new function S3ValidMode(), so that the driver will
compile.

Comment 2 Paulo César Pereira de Andrade 2008-05-21 13:26:57 UTC

  The patch doesn't apply cleanly anymore, because the typo
that caused it to become uncompilable was fixed in commit
caa3a43d9798bdc82a3660df88e694e2e65df373

  But the calls as "find_bios_string(ps3v->PciTag, ..." to
the function with prototype
"static unsigned char *find_bios_string(S3VPtr ps3v, ..."
was not applied, so this bug report is still valid.

  Actually, the obsoleted version of the patch should
now be the proper fix, and apply cleanly :-)

Comment 3 Paulo César Pereira de Andrade 2008-07-21 15:37:57 UTC

  Patch being remade to have only changes truly required
to have a functional binary.

Comment 4 Paulo César Pereira de Andrade 2008-07-21 15:38:51 UTC

Created attachment 17808 [details] [review]
0001-Correct-calls-to-find_bios_string.patch

Comment 5 Paulo César Pereira de Andrade 2008-07-28 14:57:51 UTC

  Fixed in commit 29e413c850e18f43dbd011689973399c5d7d340d.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.