Bug 14783

Summary: xorg/driver/xf86-video-r128 - Avoid usage of LoaderSymbol
Product: xorg Reporter: Paulo César Pereira de Andrade <pcpa>
Component: Driver/RadeonAssignee: xf86-video-ati maintainers <xorg-driver-ati>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium Keywords: patch
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
0001-Avoid-usage-of-LoaderSymbol.patch none

Description Paulo César Pereira de Andrade 2008-03-02 09:56:24 UTC 
Created attachment 14769 [details] [review]
0001-Avoid-usage-of-LoaderSymbol.patch

It can be dangerous. This patch is based on the previous one when r128
was in xf86-video-ati. The problem is that if gR128EntityIndex is not
explicitly marked as a public symbol, and weird things may happen when
compiling with hidden symbols.
Since the symbol is in the same shared binary of its callers, just use
it, instead of using LoaderSymbol. Could also just replace calls
getR128EntityIndex() to direct access to gR128EntityIndex.
Comment 1 Alex Deucher 2008-03-02 11:59:53 UTC 
applied:
a4fafa97b31bb7da01dd92236b42a418ca482992

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.