| Summary: | xorg/driver/xf86-video-savage - Don't call nonexisting functions and compile warning fixes | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Paulo César Pereira de Andrade <pcpa> |
| Component: | Driver/savage | Assignee: | Xorg Project Team <xorg-team> |
| Status: | RESOLVED NOTABUG | QA Contact: | Xorg Project Team <xorg-team> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | |||
|
Description
Paulo César Pereira de Andrade
2008-02-28 22:32:30 UTC
Created attachment 14703 [details] [review] 0002-Remove-declaration-and-call-to-non-existing-function.patch Created attachment 14919 [details] [review] 0003-Compile-warning-fixes.patch Added compile warning fixes patch. Patch 0001-Replace-ALLOCATE_LOCAL-DEALLOCATE_LOCAL-with-xalloc.patch should be applied if compiling with git master or 1.5 branch, otherwise the savage driver will fail due to unresolved symbols (i.e. ALLOCATE_LOCAL was previously a macro to choose between alloca/xalloc, but now it is compiled as a "missing" function call). Created attachment 15359 [details] [review] 0001-Remove-declaration-and-call-to-non-existing-function.patch Regenerate patches agains't current git master. Patch1 (Attachment 14702 [details]) was fixed in commit 6adc23cb19bfd331221df8dccb2dc88b8fc77821 Created attachment 15360 [details] [review] 0002-Compile-warning-fixes.patch Cast printf format arguments and remove unused variables. Remaining warnings are about unused variable pScreen, but it is an argument to REGION macros, that may be defined as function calls instead of "inlined", and then the argument would be used. And two other warnings due to assigning pciaddr_t (an unsigned long long) to a pointer, that should only generate a warning on 32 bit architecture. Created attachment 15858 [details] [review] 0002-Compile-warning-fixes.patch Patch2 remade to match current sources. Patch1 should still apply cleanly. Comment on attachment 15359 [details] [review] 0001-Remove-declaration-and-call-to-non-existing-function.patch Obsoleted by commit 09c4dcc658b07f2672388eb4ab5fee3ebe190fc9 Only remaining problems are arguably the warnings about void *. gcc should generate correct code to convert "%ld" format with drm_handle_t argument, and mixed code and declarations should not be a problem because xorg compilation requires c99 features. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.