Bug 14691

Summary:

libSM ansification and bug fixes.

Product:

xorg

Reporter:

Paulo César Pereira de Andrade <pcpa>

Component:

Lib/other

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED NOTABUG

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Keywords:

patch

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
0001-libSM-ansification.patch	none
0002-Allow-globals.h-to-be-included-by-multiple-files.patch	none
0003-Add-missing-prototypes.patch	none
0004-GCC-warning-fix-cast-const-char-to-char-to-m.patch	none
0001-libSM-ansification.patch	none

Description Paulo César Pereira de Andrade 2008-02-26 12:26:17 UTC

Created attachment 14591 [details] [review]
0001-libSM-ansification.patch

Like the libICE, these should have no problems as there should
not exist type promotion.

  Only problem not handled is definition of prototypes of internal
libICE functions. This probably should also be handled in libICE,
to have a single header files to define those private functions,
instead of local globals.h header file.

Comment 1 Paulo César Pereira de Andrade 2008-02-26 12:26:45 UTC

Created attachment 14592 [details] [review]
0002-Allow-globals.h-to-be-included-by-multiple-files.patch

Comment 2 Paulo César Pereira de Andrade 2008-02-26 12:27:13 UTC

Created attachment 14593 [details] [review]
0003-Add-missing-prototypes.patch

Comment 3 Paulo César Pereira de Andrade 2008-02-26 12:27:42 UTC

Created attachment 14594 [details] [review]
0004-GCC-warning-fix-cast-const-char-to-char-to-m.patch

Comment 4 Paulo César Pereira de Andrade 2008-03-13 18:37:39 UTC

Created attachment 15102 [details] [review]
0001-libSM-ansification.patch

  Missed one K&R definition, found now, when compiling
with -Wold-style-definition

Comment 5 Paulo César Pereira de Andrade 2008-07-23 13:39:25 UTC

  This was one of the first ansification patches I sent,
and the description already tells that it is not complete
because some prototypes defined in C source files were not
moved to globals.h.

  Other than that, the patch is trivial, but doesn't address
any real bugs.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.