Bug 1229

Summary: KEYBOARD symbol undefined for non-loadable server when using old keyboard driver
Product: xorg Reporter: Kristian Høgsberg <krh>
Component: Input/KeyboardAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: kem
Version: git   
Hardware: All   
OS: All   
URL: http://freedesktop.org/pipermail/release-wranglers/2004-August/000961.html
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 269, 351    
Attachments:
Description Flags
Always define KEYBOARD none

Description Kristian Høgsberg 2004-08-29 06:54:50 UTC 
See the email thread in
http://freedesktop.org/pipermail/release-wranglers/2004-August/000961.html.

A better fix would be to rename the input/keyboard directory to input/kbd so it
matches the name of driver it contains.  input/Imakefile should then be changed
so it has 

  #if UseDeprecatedKeyboardDriver
  BUILTIN=xf86KEYBOARD
  #else
  BUILTIN=KEYBOARD
  #endif

but we probably shouldn't rename directories at this point ;-)
Comment 1 Kristian Høgsberg 2004-08-29 06:59:22 UTC 
Created attachment 761 [details] [review]
Always define KEYBOARD

This patch removes the #if / #endif around the KEYBOARD definition so it always
present.  When building with LoadableServer NO and UseDeprecatedKeyboardDriver
YES, two entries in the xf86InputDriverList will have .driverName = "keyboard",
but the XF86KEYBOARD will appear first and take precedence as it should.
Comment 2 Kevin E. Martin 2004-08-29 14:06:39 UTC 
Okay, I've tested this patch, and it appears to work fine for me with both the
loader and no-loader cases.  Checking in and closing.

We should revisit this after the release and consider renaming the keyboard dir.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.