Bug 12286

Summary:

fb access incorrectly wrapped for fbPolyArc

Product:

xorg

Reporter:

Alan Hourihane <alanh>

Component:

Server/General

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Bug Depends on:

8888

Bug Blocks:

Attachments:

Description	Flags
fbPolyArc fix	none
slight update to the last one	none
stop rushing....	none
Fixes for EXA to avoid the problem also	none
an update to fix braces This includes both the fb & EXA fixes.	none

Description Alan Hourihane 2007-09-05 01:30:26 UTC

fbPolyArc calls mi functions which can end up calling the accelerated driver. 

This patch demonstrates what needs to happen to fbPolyArc to it's wrapped/unwrapped correctly.

I've just thrown this together in the hope someone can review for the 7.3 release and get this fixed as it can cause rendering glitches.

Comment 1 Alan Hourihane 2007-09-05 01:30:52 UTC

Created attachment 11425 [details] [review]
fbPolyArc fix

here's the patch

Comment 2 Alan Hourihane 2007-09-05 01:32:50 UTC

Created attachment 11426 [details] [review]
slight update to the last one

update to the last.

Comment 3 Alan Hourihane 2007-09-05 01:33:48 UTC

Created attachment 11427 [details] [review]
stop rushing....

Comment 4 Alan Hourihane 2007-09-05 01:46:59 UTC

Created attachment 11429 [details] [review]
Fixes for EXA to avoid the problem also

This patch is for EXA which bumps into similar issues caused by fbPolyArc.

We can't rely on this path as fbPolyArc can call out to mi anyway. So let's just call miPolyArc for all cases.

Comment 5 Alan Hourihane 2007-09-05 03:20:24 UTC

Note, these haven't been committed to master either.

Comment 6 Colin Harrison 2007-09-05 10:51:53 UTC

The 'if else' syntax is wrong due to missing brackets, for me.

Comment 7 Alan Hourihane 2007-09-05 11:38:23 UTC

Created attachment 11437 [details] [review]
an update to fix braces

This includes both the fb & EXA fixes.

Yeah, in the rush to get something coherent I didn't build test, and it ended up in-coherent. Sorry.

Attached is an updated patch.

Comment 8 Michel Dänzer 2007-09-25 00:41:20 UTC

EXA part pushed to master and no-pci-rework branches.

Comment 9 Alan Hourihane 2007-09-27 07:02:06 UTC

Commit the fb part and add FB_ACCESS_WRAPPER around them as well.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.