Bug 111199

Summary: Bug in dither.depth property set: Value compared to dither.mode instead of dither.depth
Product: xorg Reporter: Max <max.kammerer>
Component: Driver/nouveauAssignee: Nouveau Project <nouveau>
Status: RESOLVED MOVED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium Keywords: janitor
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Max 2019-07-23 09:38:33 UTC 
There is probably a bug in dither.depth property set cause its value compared with dither.mode:

//nouveau_connector.c
 
if (property == disp->dithering_mode) {
    if (asyc->dither.mode != val) {
        asyc->dither.mode = val;
        asyc->set.dither = true;
    }
} else
if (property == disp->dithering_depth) {
    if (asyc->dither.mode != val) { //Should be dither.depth
        asyc->dither.depth = val;
        asyc->set.dither = true; //triggers dithering regardless of dither.mode set above. Copy/Paste from above? Should be removed?
    }
}
Comment 1 Martin Peres 2019-12-04 09:50:49 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/driver/xf86-video-nouveau/issues/496.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.