Bug 105471

Summary:	[g33] [bisected] dEQP-GLES2.functional.shaders failures
Product:	Mesa	Reporter:	Clayton Craft <clayton.a.craft>
Component:	Drivers/DRI/i965	Assignee:	Mathias Fröhlich <Mathias.Froehlich>
Status:	RESOLVED FIXED	QA Contact:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity:	normal
Priority:	medium	CC:	Mathias.Froehlich
Version:	git	Keywords:	bisected, regression
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Attempt of a fix.

Description Clayton Craft 2018-03-13 01:08:05 UTC

There are approximately 2300 new dEQP test failures on g33 in the Mesa CI. The full list of failing tests can be seen here: https://craftyguy.net/paste/Kfh9QQWi


This has been bisected to the following commit:

commit 64d2a20480547d5897fd9d7b8fd306f2625138cb
Author: Mathias Fröhlich <mathias.froehlich@web.de>
Date:   Sun Mar 4 18:15:53 2018 +0100

    mesa: Make gl_vertex_array contain pointers to first order VAO members.

Comment 1 Mathias Fröhlich 2018-03-13 08:15:39 UTC

Created attachment 138068 [details] [review]
Attempt of a fix.

Does the attached patch bring us back to the old fail count?

best

Mathias

Comment 2 Mark Janes 2018-03-16 05:55:17 UTC

fixed by
98f35ad63c23805c32654843f55208e675d4e4db
Author:     Mathias Fröhlich <mathias.froehlich@gmx.net>

vbo: Correctly handle source arrays in vbo_split_copy.

The original approach did optimize away a bit too many fields.
Restablish the pointer into the original array and correctly feed that
one.

Reviewed-by: Brian Paul <brianp@vmware.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105471
Fixes: 64d2a20480547d5897fd9d7b8fd306f2625138cb
    mesa: Make gl_vertex_array contain pointers to first order VAO members.
Signed-off-by: Mathias Fröhlich <Mathias.Froehlich@web.de>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.