Attachment 14672 Details for Bug 14728 – 0002-Adjust-some-null-character-comparisons.patch

[patch] 0002-Adjust-some-null-character-comparisons.patch

0002-Adjust-some-null-character-comparisons.patch (text/plain), 1.42 KB, created by Paulo César Pereira de Andrade on 2008-02-28 16:18:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paulo César Pereira de Andrade

Created: 2008-02-28 16:18:46 UTC

Size: 1.42 KB

patch

obsolete

>From 70bf417b0691dfdc0459e900ac23ba51158f61c6 Mon Sep 17 00:00:00 2001
>From: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
>Date: Thu, 28 Feb 2008 20:52:27 -0300
>Subject: [PATCH] Adjust some null character comparisons
>
>to avoid warning about cast from pointer to integer of different size.
>---
> src/XpContext.c |    2 +-
> src/XpPrinter.c |    4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/src/XpContext.c b/src/XpContext.c
>index fc3da9c..3462259 100644
>--- a/src/XpContext.c
>+++ b/src/XpContext.c
>@@ -79,7 +79,7 @@ XpCreateContext (
> 
>     if ( locale == (char *) NULL )
>         req->localeLen = 0;
>-    else if ( *locale == (char) NULL )
>+    else if ( *locale == '\0' )
>         req->localeLen = 0;
>     else {
>         locale_len     = strlen( locale );
>diff --git a/src/XpPrinter.c b/src/XpPrinter.c
>index 7ed33b7..5899c61 100644
>--- a/src/XpPrinter.c
>+++ b/src/XpPrinter.c
>@@ -92,7 +92,7 @@ XpGetPrinterList (
>      */
>     if ( printer_name == (char *) NULL )
> 	req->printerNameLen = 0;
>-    else if ( *printer_name == (char) NULL )
>+    else if ( *printer_name == '\0' )
> 	req->printerNameLen = 0;
>     else {
> 	printer_name_len    = strlen( printer_name );
>@@ -102,7 +102,7 @@ XpGetPrinterList (
> 
>     if ( locale == (char *) NULL )
> 	req->localeLen = 0;
>-    else if ( *locale == (char) NULL )
>+    else if ( *locale == '\0' )
> 	req->localeLen = 0;
>     else {
> 	locale_len     = strlen( locale );
>-- 
>1.5.4.3
>

Actions: View | Splinter Review

Attachments on bug 14728: 14671 | 14672

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.