Attachment 41680 Details for Bug 32854 – configure.in: use AC_TRY_COMPILE to avoid a symlink attack in /tmp during compilation

[patch] configure.in: use AC_TRY_COMPILE to avoid a symlink attack in /tmp during compilation

0001-configure.in-use-AC_TRY_COMPILE-to-avoid-a-symlink-a.patch (text/plain), 1.04 KB, created by Simon McVittie on 2011-01-05 11:17:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-01-05 11:17:57 UTC

Size: 1.04 KB

patch

obsolete

>From d83d74dc6833d127032dc18b1b1aac27cb974015 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Wed, 5 Jan 2011 19:10:12 +0000
>Subject: [PATCH 1/3] configure.in: use AC_TRY_COMPILE to avoid a symlink attack in /tmp during compilation
>
>---
> configure.in |   18 +++++++-----------
> 1 files changed, 7 insertions(+), 11 deletions(-)
>
>diff --git a/configure.in b/configure.in
>index 842a359..aec3419 100644
>--- a/configure.in
>+++ b/configure.in
>@@ -1085,17 +1085,13 @@ fi
> #### gcc warning flags
> 
> cc_supports_flag() {
>-  AC_MSG_CHECKING(whether $CC supports "$@")
>-  Cfile=/tmp/foo${$}
>-  touch ${Cfile}.c
>-  $CC -c "$@" ${Cfile}.c -o ${Cfile}.o >/dev/null 2>&1
>-  rc=$?
>-  rm -f ${Cfile}.c ${Cfile}.o
>-  case $rc in
>-    0) AC_MSG_RESULT(yes);;
>-    *) AC_MSG_RESULT(no);;
>-  esac
>-  return $rc
>+  AC_MSG_CHECKING(whether $CC supports "$*")
>+  save_CFLAGS="$CFLAGS"
>+  CFLAGS="$*"
>+  AC_TRY_COMPILE([], [], [rc=yes], [rc=no])
>+  CFLAGS="$save_CFLAGS"
>+  AC_MSG_RESULT([$rc])
>+  test "x$rc" = xyes
> }
> 
> ld_supports_flag() {
>-- 
>1.7.2.3
>

Actions: View | Splinter Review

Attachments on bug 32854: 41680 | 41681 | 41682

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.