Attachment 27155 Details for Bug 22474 – Patch that fixes XVPutImage in portrait mode

[patch] Patch that fixes XVPutImage in portrait mode

fix_xv_rotated.patch (text/plain), 1.18 KB, created by Barry Scott on 2009-06-26 02:24:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Barry Scott

Created: 2009-06-26 02:24:04 UTC

Size: 1.18 KB

patch

obsolete

>diff --git a/src/i830_video.c b/src/i830_video.c
>--- a/src/i830_video.c
>+++ b/src/i830_video.c
>@@ -2488,7 +2488,7 @@ I830PutImage(ScrnInfoPtr pScrn,
> 
>         if (sync) {
> 	    BoxPtr box;
>-	    int y1, y2;
>+	    pixman_box16_t box_in_crtc_coordinates;
> 	    int pipe = -1, event, load_scan_lines_pipe;
> 
> 	    if (pixmap_is_scanout(pPixmap)) {
>@@ -2510,16 +2510,17 @@ I830PutImage(ScrnInfoPtr pScrn,
> 		}
> 
> 		box = REGION_EXTENTS(unused, clipBoxes);
>-		y1 = box->y1 - crtc->y;
>-		y2 = box->y2 - crtc->y;
>+		box_in_crtc_coordinates = *box;
>+		if (crtc->transform_in_use)
>+		    pixman_f_transform_bounds (&crtc->f_framebuffer_to_crtc, &box_in_crtc_coordinates);
> 
> 		BEGIN_BATCH(5);
> 		/* The documentation says that the LOAD_SCAN_LINES command
> 		 * always comes in pairs. Don't ask me why. */
> 		OUT_BATCH(MI_LOAD_SCAN_LINES_INCL | load_scan_lines_pipe);
>-		OUT_BATCH((y1 << 16) | y2);
>+		OUT_BATCH((box_in_crtc_coordinates.y1 << 16) | box_in_crtc_coordinates.y2);
> 		OUT_BATCH(MI_LOAD_SCAN_LINES_INCL | load_scan_lines_pipe);
>-		OUT_BATCH((y1 << 16) | y2);
>+		OUT_BATCH((box_in_crtc_coordinates.y1 << 16) | box_in_crtc_coordinates.y2);
> 		OUT_BATCH(MI_WAIT_FOR_EVENT | event);
> 		ADVANCE_BATCH();
> 	    }

Actions: View | Splinter Review

Attachments on bug 22474: 27155 | 27250

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.