Attachment 14594 Details for Bug 14691 – 0004-GCC-warning-fix-cast-const-char-to-char-to-m.patch

[patch] 0004-GCC-warning-fix-cast-const-char-to-char-to-m.patch

0004-GCC-warning-fix-cast-const-char-to-char-to-m.patch (text/plain), 1.57 KB, created by Paulo César Pereira de Andrade on 2008-02-26 12:27:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paulo César Pereira de Andrade

Created: 2008-02-26 12:27:42 UTC

Size: 1.57 KB

patch

obsolete

>From 8f93bf66be82be9e5af60522d6503337d806f1db Mon Sep 17 00:00:00 2001
>From: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
>Date: Tue, 26 Feb 2008 16:58:24 -0300
>Subject: [PATCH] GCC warning fix, cast const char *[] to char ** to match prototype.
>
>Glibc warning about NULL memcpy arguments in sm_client.c call to
>macro STORE_ARRAY8 not fixed due to macro complexity, and the fact
>that it is calling memcpy with a length argument of value 0.
>---
> src/sm_client.c  |    2 +-
> src/sm_manager.c |    2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/sm_client.c b/src/sm_client.c
>index 73fab4b..78ad2aa 100644
>--- a/src/sm_client.c
>+++ b/src/sm_client.c
>@@ -127,7 +127,7 @@ SmcOpenConnection (
> 
> 	if ((_SmcOpcode = IceRegisterForProtocolSetup ("XSMP",
> 	    SmVendorString, SmReleaseString, version_count, versions,
>-            auth_count, auth_names, auth_procs, NULL)) < 0)
>+            auth_count, (char **)auth_names, auth_procs, NULL)) < 0)
> 	{
> 	    if (errorStringRet && errorLength > 0) {
> 		strncpy (errorStringRet,
>diff --git a/src/sm_manager.c b/src/sm_manager.c
>index 279e551..d430265 100644
>--- a/src/sm_manager.c
>+++ b/src/sm_manager.c
>@@ -164,7 +164,7 @@ SmsInitialize (
> 
> 	if ((_SmsOpcode = IceRegisterForProtocolReply ("XSMP",
> 	    vendor, release, version_count, versions,
>-	    auth_count, auth_names, auth_procs, hostBasedAuthProc,
>+	    auth_count, (char **)auth_names, auth_procs, hostBasedAuthProc,
> 	    _SmsProtocolSetupProc,
> 	    NULL,	/* IceProtocolActivateProc - we don't care about
> 			   when the Protocol Reply is sent, because the
>-- 
>1.5.4.3
>

Actions: View | Splinter Review

Attachments on bug 14691: 14591 | 14592 | 14593 | 14594 | 15102

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.