Attachment 129975 Details for Bug 99999 – test: Fix copy-paste error in waiting for a message in the tests

[patch] test: Fix copy-paste error in waiting for a message in the tests

test-Fix-copy-paste-error-in-waiting-for-a-message.patch (text/plain), 1.07 KB, created by Philip Withnall on 2017-02-28 09:08:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philip Withnall

Created: 2017-02-28 09:08:24 UTC

Size: 1.07 KB

patch

obsolete

>From fc38abff631b60cff1bfb946388288dca972f7d6 Mon Sep 17 00:00:00 2001
>From: Philip Withnall <withnall@endlessm.com>
>Date: Tue, 28 Feb 2017 08:55:26 +0000
>Subject: [PATCH] test: Fix copy-paste error in waiting for a message in the
> tests
>
>The parameters to the test_pending_call_store_reply() call should match
>those to the dbus_pending_call_set_notify() immediately after.
>
>Coverity ID: 141876
>
>Signed-off-by: Philip Withnall <withnall@endlessm.com>
>
>https://bugs.freedesktop.org/show_bug.cgi?id=99999
>---
> test/sd-activation.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/test/sd-activation.c b/test/sd-activation.c
>index ff4a657..cb5a7c7 100644
>--- a/test/sd-activation.c
>+++ b/test/sd-activation.c
>@@ -880,7 +880,7 @@ test_transient_services (Fixture *f,
>       /* It fails. */
> 
>       if (dbus_pending_call_get_completed (pc))
>-        test_pending_call_store_reply (pc, &reply);
>+        test_pending_call_store_reply (pc, &m);
>       else if (!dbus_pending_call_set_notify (pc, test_pending_call_store_reply,
>             &m, NULL))
>         g_error ("OOM");
>-- 
>2.9.3

Actions: View | Splinter Review

Attachments on bug 99999: 129975 | 129976

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.