Attachment 128996 Details for Bug 99435 – dbus-connection: Remove a duplicate _dbus_list_clear() call

[patch] dbus-connection: Remove a duplicate _dbus_list_clear() call

dbus-connection-Remove-a-duplicate-dbuslistclear-c.patch (text/plain), 1018 bytes, created by Philip Withnall on 2017-01-17 08:36:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philip Withnall

Created: 2017-01-17 08:36:28 UTC

Size: 1018 bytes

patch

obsolete

>From 50f801911b9d251e4b150f6cc5d12f9332fe83f8 Mon Sep 17 00:00:00 2001
>From: Philip Withnall <withnall@endlessm.com>
>Date: Tue, 17 Jan 2017 08:35:07 +0000
>Subject: [PATCH] dbus-connection: Remove a duplicate _dbus_list_clear() call
>
>This was doing no harm (clearing an already-cleared list is a no-op),
>but it was also pointless.
>
>Signed-off-by: Philip Withnall <withnall@endlessm.com>
>
>https://bugs.freedesktop.org/show_bug.cgi?id=99435
>---
> dbus/dbus-connection.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/dbus/dbus-connection.c b/dbus/dbus-connection.c
>index 319987e..f42dac4 100644
>--- a/dbus/dbus-connection.c
>+++ b/dbus/dbus-connection.c
>@@ -2758,8 +2758,6 @@ _dbus_connection_last_unref (DBusConnection *connection)
>   _dbus_hash_table_unref (connection->pending_replies);
>   connection->pending_replies = NULL;
>   
>-  _dbus_list_clear (&connection->filter_list);
>-  
>   _dbus_list_foreach (&connection->outgoing_messages,
>                       free_outgoing_message,
> 		      connection);
>-- 
>2.9.3

Actions: View | Splinter Review

Attachments on bug 99435: 128996

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.