Attachment 114004 Details for Bug 89428 – dbus-print-message: conditionalize Unix FD handling on DBUS_UNIX

[patch] dbus-print-message: conditionalize Unix FD handling on DBUS_UNIX

0002-dbus-print-message-conditionalize-Unix-FD-handling-o.patch (text/plain), 1.08 KB, created by Simon McVittie on 2015-03-04 18:53:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2015-03-04 18:53:36 UTC

Size: 1.08 KB

patch

obsolete

>From 321e8b2795370da76c9e7afe1a0284865085c96f Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Wed, 4 Mar 2015 12:11:20 +0000
>Subject: [PATCH 2/2] dbus-print-message: conditionalize Unix FD handling on
> DBUS_UNIX
>
>We close() the fd after we have printed it, but close() isn't
>standard functionality on Windows. Unix FD-passing is never going
>to work on non-Unix platforms anyway.
>---
> tools/dbus-print-message.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/tools/dbus-print-message.c b/tools/dbus-print-message.c
>index bd0817c..1891da7 100644
>--- a/tools/dbus-print-message.c
>+++ b/tools/dbus-print-message.c
>@@ -505,6 +505,7 @@ print_iter (DBusMessageIter *iter, dbus_bool_t literal, int depth)
>             break;
>           }
> 
>+#ifdef DBUS_UNIX
>         case DBUS_TYPE_UNIX_FD:
>           {
>             int fd;
>@@ -520,6 +521,7 @@ print_iter (DBusMessageIter *iter, dbus_bool_t literal, int depth)
> 
>             break;
>           }
>+#endif
> 
>         default:
>           printf (" (dbus-monitor too dumb to decipher arg type '%c')\n", type);
>-- 
>2.1.4
>

Actions: View | Splinter Review

Attachments on bug 89428: 114003 | 114004

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.