Bug 70869 - EDITING: Data series and data ranges are is mixed up after copy of chart if sheet name contains the locale list separator
Summary: EDITING: Data series and data ranges are is mixed up after copy of chart if s...
Status: VERIFIED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
4.0.4.2 release
Hardware: Other Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: BSA target:4.2.5
Keywords: regression
: 72411 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-10-25 17:42 UTC by Peter C. S. Scholtens
Modified: 2016-10-21 16:36 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Worksheet with an example chart to demonstrate the bug (19.35 KB, application/vnd.oasis.opendocument.spreadsheet)
2013-10-25 17:42 UTC, Peter C. S. Scholtens
Details
Screenshot of the original chart (77.71 KB, image/png)
2013-10-25 17:47 UTC, Peter C. S. Scholtens
Details
Copied sheet contains wrong references (51.93 KB, image/png)
2013-10-25 17:48 UTC, Peter C. S. Scholtens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter C. S. Scholtens 2013-10-25 17:42:11 UTC
Created attachment 88118 [details]
Worksheet with an example chart to demonstrate the bug

Problem description: 

When copying a chart from the first worksheet to a second worksheet, the data series and data ranges are mixed up, only if the sheet name contains a comma "," character.


Steps to reproduce:

1) Open the attached file "bug.ods"
2) Make a new sheet by pressing the "+" button, next to the sheet name.
3) Replace the underscore character "_" with a comma" ," in the name of the first sheet called "My_Sheet"
4) Select the chart from "My,Sheet" and copy it (Ctrl+C).
5) Paste the chart in Sheet2 (with Ctrl+V)

Current behavior:

Both data series and data ranges are mixed up: one series missing, the other referencing to the wrong cells.

Expected behavior:

Same picture with correct data ranges.
Operating System: Ubuntu
Version: 4.0.4.2 release
Comment 1 Peter C. S. Scholtens 2013-10-25 17:47:44 UTC
Created attachment 88119 [details]
Screenshot of the original chart
Comment 2 Peter C. S. Scholtens 2013-10-25 17:48:43 UTC
Created attachment 88120 [details]
Copied sheet contains wrong references
Comment 3 Peter C. S. Scholtens 2013-10-26 07:18:39 UTC
The bug has been observed in a.o. a virtualbox with this environment:

3.2.0-55-generic-pae #85-Ubuntu SMP i686 athlon i386 GNU/Linux

After downloading and compiling the git release in this machine, the bug is still present in the git revision of yesterday with commit hash: 
 fed7a57fcdabbc0c0f570d9b6360522ae22f5e0a

Also seen in the Windows environment (release 4.0.6).
Comment 4 Dominique Boutry 2013-10-27 16:06:10 UTC
Unable to reproduce with LibO 4.1.2.3 on Win7
Comment 5 Cor Nouws 2013-10-30 21:33:05 UTC
Hi Peter,

The Copy & Paste goes fine for me in 4.1.3.1 and 4.0.6 on Ubuntu.
Sory I cannot confirm.
Can you test a more recent version then 4.0.4 too ?
thanks,
Cor
Comment 6 Peter C. S. Scholtens 2013-10-31 11:01:52 UTC
Some observations:


A) The sequence of steps to reproduce the error is important. Only if the copy action (Ctrl-C) is done AFTER renaming "My_Sheet" to "My,Sheet" it goes wrong. If the copy action is done before the rename action, nothing goes wrong. From this I conclude the error is present when copying the chart to the (internal?) clipboard.


B) The bug is NOT reproducible in the 32-bit (Dutch) LibreOffice version: 3.5.7.2 build 350m1:build2 (default from Ubuntu 12.04LTS). Tested in Virtualbox.


C) The bug is STILL reproducible in version 4.0.6.2 (64-bit, native machine), downloaded from the LO website.


D) The bug is STILL reproducible in version 4.0.6.2+ (64-bit, native machine) from the git repository (last commit Thu Oct 17), hash 23c7aeb5ec633674a51b41e936ad9708e502841b


E) The bug is STILL reproducible in HEAD from the git repository (64-bit, native machine) (last commit Sun Oct 27), hash 876111ad316890c3a4bf9dd837246a8af73517c8


F) While running the debug run of HEAD, and executing the copy step I've seen the function DataSequenceToDoubleSequence() is called six times instead of four times (as in the case without any error), generating this warning:

warn:legacy.osl:11474:1:chart2/source/tools/CommonConverters.cxx:433: OSL_ASSERT: xDataSequence.is()

Any suggestions how to proceed are welcome!
Comment 7 Stephan van den Akker 2013-11-14 16:03:26 UTC
Reproducible on openSuSE 12.3 (64-bit) in MASTER:

Tools | Options -> Language Settings -> Locale settings = English (UK)

- Version: 4.2.0.0.alpha1+ Build ID: 439b518b1a96b8cffd96da6fd060e7be074a2035
- Version 4.0:build-305 (Build ID: 400m0(Build:305))

Not reproducible on the same system in any of the tested versions when:

Tools | Options -> Language Settings -> Locale settings = Dutch (Netherlands)

Probably the reason why Cor doesn't see it.

The comma in the sheet name is erroneously interpreted as a list separator
Comment 8 Stephan van den Akker 2013-11-14 16:19:21 UTC
@Cor, Dominique:

Try replacing _ with a semicolon (list separator in Dutch and French). You probably will be able to reproduce the problem.
Comment 9 Cor Nouws 2013-11-17 12:11:27 UTC
thanks Stephan, that helps.
I change the summary accordingly. OK, Peter?
Comment 10 Stephan van den Akker 2013-12-07 19:24:23 UTC
*** Bug 72411 has been marked as a duplicate of this bug. ***
Comment 11 Stephan van den Akker 2013-12-07 19:30:15 UTC
Marking this as a regression because user Francisco reports that the problem is not present in LO version 3.5. (see fdo#72411)
Comment 12 Stephan van den Akker 2013-12-07 20:27:45 UTC
I can confirm that the problem is not reproducible on openSuSE 11.4 (32-bit) in
LibreOffice 3.5:build-413 Build ID: 350m1(Build:413).

A regression indeed.
Comment 13 Kohei Yoshida 2014-05-17 14:23:48 UTC
Tested with 4.2.5 and this is no longer reproducible.
Comment 14 Peter C. S. Scholtens 2014-05-18 21:06:40 UTC
As the original poster, I can confirm that in the latest git update the bug is solved.
Comment 15 Cor Nouws 2014-06-22 14:27:03 UTC
(In reply to comment #14)
> As the original poster, I can confirm that in the latest git update the bug
> is solved.

thanks Peter!
Comment 16 Thales Maia 2015-03-05 16:50:34 UTC
(In reply to Cor Nouws from comment #15)
> (In reply to comment #14)
> > As the original poster, I can confirm that in the latest git update the bug
> > is solved.
> 
> thanks Peter!

I can still reproduce it on LO 4.2.7.2

1) Create the chart with random data
2) In the name of the series, put a string "something"
3) Copy and paste the chart
4) Reference lost

Took me sometime to discover the workaround
Put the string in a cell.
Point the name of the series to the cell.
Now you can copy and paste.
Comment 17 Francisco 2015-03-05 18:01:02 UTC
(In reply to Thales Maia from comment #16)
> (In reply to Cor Nouws from comment #15)
> > (In reply to comment #14)
> > > As the original poster, I can confirm that in the latest git update the bug
> > > is solved.
> > 
> > thanks Peter!
> 
> I can still reproduce it on LO 4.2.7.2
> 
> 1) Create the chart with random data
> 2) In the name of the series, put a string "something"
> 3) Copy and paste the chart
> 4) Reference lost
> 
> Took me sometime to discover the workaround
> Put the string in a cell.
> Point the name of the series to the cell.
> Now you can copy and paste.

Thales, it seems to be that you are decribing another bug (name of a series is lost when it's a string instead of a cell range), which I can't find its URL right now.

Moreover, since LibO 4.2 has ended its life cycle, you should check bugs using LibO 4.3 or 4.4 :-)

Regards