Bug 19030 - libxklavier Cygwin patch
Summary: libxklavier Cygwin patch
Status: RESOLVED FIXED
Alias: None
Product: libxklavier
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other Cygwin
: medium normal
Assignee: Sergey V. Udaltsov
QA Contact: Sergey V. Udaltsov
URL: http://cygwinports.org/
Whiteboard:
Keywords: NEEDINFO
Depends on:
Blocks:
 
Reported: 2008-12-11 15:39 UTC by Yaakov Selkowitz
Modified: 2008-12-14 02:19 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
no-undefined patch (1.05 KB, patch)
2008-12-11 15:39 UTC, Yaakov Selkowitz 		Details | Splinter Review
View All

Description Yaakov Selkowitz 2008-12-11 15:39:49 UTC 
Created attachment 21069 [details] [review]
no-undefined patch

I'm attaching a patch which fixes the build of libxklavier-3.8 for Cygwin.

* libxklavier/Makefile.am (libxklavier_la_LDFLAGS): Add -no-undefined for Cygwin.
(libxklavier_la_LIBADD): Move link libraries here.
* tests/Makefile.am (LDADD): Link libraries go in LDADD, not LDFLAGS.
Comment 1 Sergey V. Udaltsov 2008-12-11 16:08:11 UTC 
LDADD and LIBADD is ok, thanks. Why do you need -no-undefined?
Comment 2 Yaakov Selkowitz 2008-12-11 16:42:33 UTC 
On Cygwin and MinGW, libraries must have all symbols resolved at link time.  libtool therefore requires that you indicate that this has been handled by passing -no-undefined.  Without this, libtool will only create a static library on these platforms, since there are a few legitimate cases where libraries require a symbol to be provided by the dependent program (e.g. libxcb-wm, KDE3 libkscreensaver).  As long as -no-undefined is true (which it is), this flag doesn't affect other platforms.
Comment 3 Sergey V. Udaltsov 2008-12-14 02:19:02 UTC 
Ok, committed. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.