| Summary: | dbus-object-tree: Correctly report failure from an internal test | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Philip Withnall <bugzilla> |
| Component: | core | Assignee: | D-Bus Maintainers <dbus> |
| Status: | RESOLVED FIXED | QA Contact: | D-Bus Maintainers <dbus> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
| Attachments: |
dbus-object-tree: Correctly report failure from an internal test
dbus-object-tree test: tolerate OOM in run_decompose_tests() |
||
|
Description
Philip Withnall
2017-02-10 11:07:51 UTC
Created attachment 129473 [details] [review] dbus-object-tree: Correctly report failure from an internal test Coverity ID: 54711 Signed-off-by: Philip Withnall <withnall@endlessm.com> Doing some more testing today, it looks like this might break `make check`, although I’m not sure how I didn’t catch this before. I need to find time to take a closer look. Created attachment 129556 [details] [review] dbus-object-tree test: tolerate OOM in run_decompose_tests() This test is run repeatedly, with simulated out-of-memory conditions at different points. If one of these was during run_decompose_tests(), the test was recorded as failing. Before Philip fixed it, this was masked by the failure not being reported correctly (CID: #54711). Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=99758 --- Yay OOM-handling. Comment on attachment 129556 [details] [review] dbus-object-tree test: tolerate OOM in run_decompose_tests() Review of attachment 129556 [details] [review]: ----------------------------------------------------------------- ++ Fixed in git for 1.11.10, thanks |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.