Bug 99724

Summary: test: Add some OOM paths to various tests
Product: dbus Reporter: Philip Withnall <bugzilla>
Component: coreAssignee: D-Bus Maintainers <dbus>
Status: RESOLVED FIXED QA Contact: D-Bus Maintainers <dbus>
Severity: normal    
Priority: medium CC: bugzilla
Version: unspecifiedKeywords: patch
Hardware: All   
OS: All   
Whiteboard: review+
i915 platform: i915 features:
Attachments: test: Add some OOM paths to the test-pending-call-timeout test
test: Add some OOM paths to the shell-test
test: Add a missing OOM path in manual-dir-iter test
dbus-message-util: Add some missing OOM paths to an internal test
dbus-list: Add some missing OOM paths to an internal test
dbus-message-factory: Add some missing OOM paths to an internal test

Description Philip Withnall 2017-02-09 09:47:16 UTC
Another trivial patch attached.
Comment 1 Philip Withnall 2017-02-09 09:47:18 UTC
Created attachment 129427 [details] [review]
test: Add some OOM paths to the test-pending-call-timeout test

This is mostly pointless, but will shut Coverity up.

Coverity ID: 54718

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Philip Withnall 2017-02-09 10:14:16 UTC
Created attachment 129428 [details] [review]
test: Add some OOM paths to the shell-test

I am increasingly of the opinion that this is a gigantic waste of time.
But at least Coverity will be happy.

Coverity IDs: 60585, 60586

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 3 Philip Withnall 2017-02-09 10:14:19 UTC
Created attachment 129429 [details] [review]
test: Add a missing OOM path in manual-dir-iter test

Odd that this one was missing but all the other ones were in place.

Coverity ID: 54721

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 4 Philip Withnall 2017-02-09 10:14:22 UTC
Created attachment 129430 [details] [review]
dbus-message-util: Add some missing OOM paths to an internal test

Coverity ID: 54688

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 5 Philip Withnall 2017-02-10 11:09:39 UTC
Created attachment 129474 [details] [review]
dbus-list: Add some missing OOM paths to an internal test

Coverity ID: 54715

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 6 Philip Withnall 2017-02-10 11:09:53 UTC
Created attachment 129475 [details] [review]
dbus-message-factory: Add some missing OOM paths to an internal test

Coverity ID: 54692

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 7 Simon McVittie 2017-02-10 15:13:22 UTC
Looks fine as far as here.
Comment 8 Philip Withnall 2017-02-13 13:04:43 UTC
(In reply to Simon McVittie from comment #7)
> Looks fine as far as here.

That’s all of them now.
Comment 9 Simon McVittie 2017-02-13 16:41:56 UTC
Fixed in git for 1.11.10, thanks
Comment 10 Philip Withnall 2017-02-14 09:39:50 UTC
(In reply to Philip Withnall from comment #3)
> Created attachment 129429 [details] [review] [review]
> test: Add a missing OOM path in manual-dir-iter test
> 
> Odd that this one was missing but all the other ones were in place.
> 
> Coverity ID: 54721
> 
> Signed-off-by: Philip Withnall <withnall@endlessm.com>

Looks like this one wasn’t pushed to master.
Comment 11 Simon McVittie 2017-02-14 17:54:55 UTC
(In reply to Philip Withnall from comment #10)
> Looks like this one wasn’t pushed to master.

Really applied. Sorry about that.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.