| Summary: | [ilk bisected] "drm/i915: Type safe register read/write" -> poor/nonexistent IPS | ||
|---|---|---|---|
| Product: | DRI | Reporter: | Carlos Jimenez <javashin1986> |
| Component: | DRM/Intel | Assignee: | Ville Syrjala <ville.syrjala> |
| Status: | CLOSED WORKSFORME | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | intel-gfx-bugs |
| Version: | unspecified | Keywords: | bisected, regression |
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | ILK | i915 features: | |
| Attachments: | |||
|
Description
Carlos Jimenez
2017-01-28 09:37:45 UTC
Please Help Me Here What I can Do. Thanks in advance. I'm pretty sure the git bisect result is not right. Since that one is probably impossible to revert, you should try building the supposedly good commit before that (i.e. f0f59a00a1c9be^) and the supposedly bad commit, and verify the bisect. Ok Will Do Compile Those Commits Thanks. I taked the cloned kernel git repo unmodified an I did git reset --hard f0f59a00a1c9be11038bef5aa735ed7dd985f9cf to verufy is the bug is there. One Question on the git kernel cloned repo unmodified when i do git log and i hit / to search for f0f59a00a1c9be11038bef5aa735ed7dd985f9cf the commot before this one is 4fe5dc4873663fc4cfbdae7a45a1b4378a2d7993 arm64: dts: Enable HS200 mode operation on exynos7-espresso and when i do git reset --hard f0f59a00a1c9be11038bef5aa735ed7dd985f9cf the git log shows that the commit before is 9bca5d0ca76c0ce029e2b43cf081863e7e8f6768 drm/i915: Add missing ')' to SKL_PS_ECC_STAT define which one of the commits before f0f59a00a1c9be11038bef5aa735ed7dd985f9cf i have to compile ? When You Say : I'm pretty sure the git bisect result is not right. Since that one is probably impossible to revert, you should try building the supposedly good commit before that (i.e. f0f59a00a1c9be^) and the supposedly bad commit, and verify the bisect. "the supposedly good commit before that" which good commit ? Confirmed the Bug/Regression is on Bisecting: 3 revisions left to test after this (roughly 2 steps) #BAD# [f0f59a00a1c9be11038bef5aa735ed7dd985f9cf] drm/i915: Type safe register read/write Linux darkmaza 4.3.0-rc3+ #1 SMP PREEMPT Sat Jan 28 14:18:52 AST 2017 x86_64 Intel(R) Core(TM) i3 CPU M 380 @ 2.53GHz GenuineIntel GNU/Linux Created attachment 129199 [details]
DMESG kernel 4.3.0-rc3+ with Regression/Bug Slowness commit f0f59a00a1c9be11038bef5aa735ed7dd985f9cf
The Git Bisect I did is not wrong im pretty sure is ok i fallow this guide https://wiki.gentoo.org/wiki/Kernel_git-bisect very nice and i build 13 kernels wasting my cpu cycles . This need to be fixed I dont know how but there has to be a solution for this problem i hope some one can help me . Thanks in Advance. 1) Build 9bca5d0ca76c ("drm/i915: Add missing ')' to SKL_PS_ECC_STAT define") and see if that commit is good or bad.
2) Build f0f59a00a1c9 ("drm/i915: Type safe register read/write") and see if that commit is good or bad.
(In reply to Carlos Jimenez from comment #7) > Confirmed the Bug/Regression is on Bisecting: 3 revisions left to test after > this (roughly 2 steps) > #BAD# [f0f59a00a1c9be11038bef5aa735ed7dd985f9cf] drm/i915: Type safe > register read/write > > > Linux darkmaza 4.3.0-rc3+ #1 SMP PREEMPT Sat Jan 28 14:18:52 AST 2017 x86_64 > Intel(R) Core(TM) i3 CPU M 380 @ 2.53GHz GenuineIntel GNU/Linux And this "4.3.0-rc3+" is bogus, because the commit you claim is bad was first merged in v4.5-rc1. Doing git reset --hard 9bca5d0ca76c0ce029e2b43cf081863e7e8f6768
1) Build 9bca5d0ca76c ("drm/i915: Add missing ')' to SKL_PS_ECC_STAT define") and see if that commit is good or bad.
Im Going To Build It
i just did what you told me
2) Build f0f59a00a1c9 ("drm/i915: Type safe register read/write") and see if that commit is good or bad. and i confirmed this commit has the bug
Why
"And this "4.3.0-rc3+" is bogus, because the commit you claim is bad was first merged in v4.5-rc1."
i did git reset --hard f0f59a00a1c9be11038bef5aa735ed7dd985f9cf and git checkout the kernel 4.3.0-rc3+ so what is wrong ?????? this is a unmodified git repo .
And
git reset --hard 9bca5d0ca76c0ce029e2b43cf081863e7e8f6768
Checking out files: 100% (35/35), done.
HEAD is now at 9bca5d0ca76c drm/i915: Add missing ')' to SKL_PS_ECC_STAT define
Checkout The kernel
VERSION = 4
PATCHLEVEL = 3
SUBLEVEL = 0
EXTRAVERSION = -rc3
NAME = Hurr durr I'ma sheep
Too
And Im Gonna Build it again which was already compiled by the git bisect .
to confirm what we already know is GOOD
Here is Something To Know tag name v4.5-rc1 (b13adfcdf288a00a7e58556f326ecb56fbb53b92) tag date 2016-01-24 21:06:57 (GMT) tagged by Linus Torvalds <torvalds@linux-foundation.org> tagged object \ f0f59a00a1c9be11038bef5aa735ed7dd985f9cf is the first bad commit commit f0f59a00a1c9be11038bef5aa735ed7dd985f9cf Author: Ville Syrjälä <ville.syrjala@linux.intel.com> Date: Wed Nov 18 15:33:26 2015 +0200 look at the dates excuseme if im wrong but how f0f59a00a1c9be11038bef5aa735ed7dd985f9cf whas merged in the v4.5-rc1 which dates to 2016-01-24 21:06:57 and the commit Date: Wed Nov 18 15:33:26 2015 +0200 ? Commit 9bca5d0ca76c0ce029e2b43cf081863e7e8f6768 drm/i915: Add missing ')' to SKL_PS_ECC_STAT define Confirmed As Good Commit here Linux darkmaza 4.3.0-rc3+ #1 SMP PREEMPT Sat Jan 28 16:46:21 AST 2017 x86_64 Intel(R) Core(TM) i3 CPU M 380 @ 2.53GHz GenuineIntel GNU/Linux Created attachment 129200 [details]
DMESG kernel 4.3.0-rc3+ with NO Regression/Bug Slowness commit 9bca5d0ca76c0ce029e2b43cf081863e7e8f6768
(In reply to Jani Nikula from comment #10) > 1) Build 9bca5d0ca76c ("drm/i915: Add missing ')' to SKL_PS_ECC_STAT > define") and see if that commit is good or bad. > > 2) Build f0f59a00a1c9 ("drm/i915: Type safe register read/write") and see if > that commit is good or bad. DONE AND DONE What Else I Need To Do To Prove there is a Regression In The Kernel Which Is Affecting Me And Maybe Other People. Created attachment 129204 [details]
Kernel Build With kernel 4.10-rc5 i915 disabled vesafb enabled Compiled kernel in 12 minutes
This Test i did with the kernel 4.10-rc5 proves that the slowness is caused by the intel drm i915 driver .
(In reply to Carlos Jimenez from comment #18) > Created attachment 129204 [details] > Kernel Build With kernel 4.10-rc5 i915 disabled vesafb enabled Compiled > kernel in 12 minutes > > This Test i did with the kernel 4.10-rc5 proves that the slowness is caused > by the intel drm i915 driver . In the Console CLOSING THIS BUG Carlos you may drop this bug if you want, but a little patience would be appreciated. Present the facts, what are the "make clean && time make -j3" timings for that pair of kernels? Do you have intel_ips compiled in on later kernels? What does powertop report during the compilations? I gave this a quick whirl on my ILK but didn't see any performance changes whatsoever. Long ago I tried to figure out what IPS was doing on that particular machine, and at the time it seemed to be always thermally limited as soon as the GPU became active. So without tracing the IPS stuff again I can't actually say with 100% certainty that there isn't any change in the behaviour. I might do that at some point if I get bored enough. I did re-read the patch several times, but I still can't spot any functional changes in there. I haven't noticed anything unusual yet on my ilk (but that has a dead cpu fan!), but I've been mostly concentrating on fixing up gem tests. Ville & Chris - Do you have some concrete ideas on this? To be or not to be... Reporter, do you still have issues or some comments? No feedback and cannot be reproduced by Ville/Chris. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.