Bug 98803

Summary:	Fix mistakes in file "randrproto.txt"
Product:	xorg	Reporter:	AHX2323
Component:	Protocol/Core	Assignee:	Xorg Project Team <xorg-team>
Status:	RESOLVED MOVED	QA Contact:	Xorg Project Team <xorg-team>
Severity:	minor
Priority:	medium	CC:	airlied
Version:	git	Keywords:	patch
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description AHX2323 2016-11-21 09:48:58 UTC

Patch for file

https://cgit.freedesktop.org/xorg/proto/randrproto/plain/randrproto.txt


diff --git a/randrproto.txt b/randrproto.txt
index c06bc90..29ffd24 100644
--- a/randrproto.txt
+++ b/randrproto.txt
@@ -2359,7 +2359,7 @@ A.1 Common Types
 A.1.1 Common Types added in version 1.5 of the protocol
 
 ┌───
-    MONITORINFO (16 + 4*n)
+    MONITORINFO (24 + 4*n)
 	4	ATOM		name
 	1	BOOL		primary
 	1	BOOL		automatic
@@ -2969,7 +2969,7 @@ A.2.3 Protocol Requests added with version 1.4
 	2	CARD16			sequence number
 	4	1+c+o+(a*2)+(n+p)/4		reply length
 	4	TIMESTAMP		timestamp
-	4	CARD32			capabilities
+	4	PROVIDER_CAPS		capabilities
 	2	c			number of crtcs
 	2	o 			number of outputs
 	2	a 			number of associated providers
@@ -2978,7 +2978,7 @@ A.2.3 Protocol Requests added with version 1.4
 	4c	LISTofCRTC		crtcs
 	4o	LISTofOUTPUT		outputs
 	4a	LISTofPROVIDER		associated providers
-	4a	CARD32			associated provider capability
+	4a	LISTofPROVIDER_CAPS	associated provider capability
 	n	STRING8			name
 	p				unused, p=pad(n)
 └───
@@ -3054,11 +3054,11 @@ A.2.3 Protocol Requests added with version 1.4
 	4	ATOM			property
 	4	ATOM			type
 	1	CARD8			format
-	1				mode
+	2				mode
 		0	Replace
 		1	Prepend
 		2	Append
-	2				unused
+	1				unused
 	4	CARD32			length of data in format units
 					(= n for format = 8)
 					(= n/2 for format = 16)

Comment 1 AHX2323 2016-11-23 09:44:53 UTC

Please, ignore last 14 lines of my patch - this is my mistake.

Also found other issues.

* See line 2362: definition of structure "MONITORINFO".
-- Field "ncrtcs" of  structure listed at line 2366 and not listed at line 417. Field "ncrtcs" not used any more?
-- Field "crtcs" of type "CRTC" should be replaced on field "outputs" of type "LISTofOUTPUT"?
-- How to detect count of OUTPUTs in LISTofOUTPUT?
-- Also need fix size of "MONITORINFO" structure.

* See line 1610: field "get_active" of type "BOOL". See line 3117: "get_active" missing.

* See line 2965: field "config-timestamp" of type "TIMESTAMP". See line 1400: "config-timestamp" missing.

Please, fix spec.

Comment 2 GitLab Migration User 2018-08-10 19:55:18 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/proto/xorgproto/issues/5.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.