Bug 98485

Summary: test_vec4_cmod_propagation.cpp:372:26: error: ‘brw_reg’ is an inaccessible base of ‘brw::dst_reg’
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact: mesa-dev
Severity: normal    
Priority: medium CC: currojerez, itoral
Version: 13.0Keywords: bisected, regression
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2016-10-28 21:06:08 UTC 
mesa: e6aeeace6953a7007d98082e3f44bff40a44106d (master 13.1.0-devel)

  CXX      test_vec4_cmod_propagation.o
test_vec4_cmod_propagation.cpp: In member function ‘virtual void cmod_propagation_test_intervening_dest_write_Test::TestBody()’:
test_vec4_cmod_propagation.cpp:372:26: error: ‘brw_reg’ is an inaccessible base of ‘brw::dst_reg’
    bld.ADD(offset(dest, 2), src0, src1);
                          ^


66fcfa6894ab61a8cb70955f4a4113729e4a8099 is the first bad commit
commit 66fcfa6894ab61a8cb70955f4a4113729e4a8099
Author: Iago Toral Quiroga <itoral@igalia.com>
Date:   Mon Oct 3 13:33:12 2016 +0200

    i965/vec4: make offset() work in terms of a simd width and scalar components
    
    So that it has the same semantics as the scalar backend implementation. The
    helper will now take a simd width (which is always 8 in vec4 mode) and step
    as many scalar components as specified by that width, respecting the size of
    the scalar channels.
    
    v2 (Curro):
      - Remove the assertion in offset(), byte_offset() has the same checks.
      - Use byte_offset() directly instead of add_byte_offset().
      - Make things more clear by explicitly including the vertical stride
        in the byte offset expression.
    
    Reviewed-by: Francisco Jerez <currojerez@riseup.net>

:040000 040000 61fda73ca05d5d657615121949183d07f9b05632 2c08f32494029dac5aabfcf483b70c9314d91750 M	src
bisect run success
Comment 1 Vinson Lee 2016-10-29 07:43:57 UTC 
commit cab3d4673922e2beb1f86f59c6aef17f55da3ac2
Author: Jason Ekstrand <jason.ekstrand@intel.com>
Date:   Fri Oct 28 14:47:20 2016 -0700

    i965: Fix make check after 66fcfa6894ab6
    
    Commit 66fcfa6894ab6 changed the vec4 version of offset() to have 3
    parameters instead of 2 but the vec4_cmod_propagation test was never
    updated.
    
    Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.