Bug 98345

Summary: dEQP EGL: negative test failed w/ invalid return
Product: Mesa Reporter: Randy <randy.xu>
Component: EGLAssignee: Tapani Pälli <lemody>
Status: RESOLVED FIXED QA Contact: mesa-dev
Severity: normal    
Priority: medium    
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 98315    

Description Randy 2016-10-20 06:56:20 UTC 
dEQP-EGL.functional.negative_api.create_context.qpa: <Result StatusCode="Fail">Got invalid value</Result>
dEQP-EGL.functional.negative_api.create_pbuffer_surface.qpa: <Result StatusCode="Fail">Got invalid error</Result>



Mesa git top commit: 389d6dedbe75defe07216ad761569a9b94f44e58
dEQP git top commit: ca988480be945772473f9256b6ae91fa6aa62bd1
Comment 1 Tapani Pälli 2016-10-20 11:38:12 UTC 
it seems currently to return EGL_BAD_CONFIG while spec defines EGL_BAD_MATCH, will send a patch
Comment 2 Tapani Pälli 2016-10-25 05:00:28 UTC 
commit 282b87dd03317ff39eb409b0ac2cbdc17d7e5aa3
Author: Tapani Pälli <tapani.palli@intel.com>
Date:   Thu Oct 20 13:51:40 2016 +0300

    egl: fix type mismatch error type in _eglInitSurface
    
    EGL spec defines EGL_BAD_MATCH for windows, pixmaps and pbuffers in
    case where user creates a surface but config does not support rendering
    to such surface type.
    
    Following quotes are from EGL 1.5 spec 3.5 "Rendering Surfaces" :
    
    for eglCreatePlatformWindowSurface, eglCreateWindowSurface:
    
       "If config does not support rendering to windows (the EGL_SURFACE_TYPE
       attribute does not contain EGL_WINDOW_BIT ), an EGL_BAD_MATCH error is
       generated."
    
    for eglCreatePbufferSurface:
    
       "If config does not support pbuffers, an EGL_BAD_MATCH error is
       generated."
    
    for eglCreatePlatformPixmapSurface, eglCreatePixmapSurface:
    
       "If config does not support rendering to pixmaps (the EGL_SURFACE_TYPE
       attribute does not contain EGL_PIXMAP_BIT ), an EGL_BAD_MATCH error is
       generated."
    
    Fixes following dEQP test:
    
       dEQP-EGL.functional.negative_api.create_pbuffer_surface
    
    Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
    Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.