| Summary: | [BSW] kms_cursor_crc some subcases fail | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | DRI | Reporter: | cprigent <christophe.prigent> | ||||||||||||||
| Component: | DRM/Intel | Assignee: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||||||||||
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||||||||||
| Severity: | normal | ||||||||||||||||
| Priority: | medium | CC: | bugs, intel-gfx-bugs, ricardo.vega | ||||||||||||||
| Version: | unspecified | ||||||||||||||||
| Hardware: | x86-64 (AMD64) | ||||||||||||||||
| OS: | Linux (All) | ||||||||||||||||
| Whiteboard: | ReadyForDev | ||||||||||||||||
| i915 platform: | BSW/CHT | i915 features: | display/Other | ||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
cprigent
2016-09-28 14:23:44 UTC
Created attachment 126829 [details]
HSW__kms_cursor_crc__kern.log
Still valid for 4.10.0-drm-tip-qa-ww9-commit-7f38bb9+ (HSW-1-D54250WYK) igt@kms_cursor_crc@cursor-128x128-dpms Fail igt@kms_cursor_crc@cursor-128x128-offscreen Fail igt@kms_cursor_crc@cursor-128x128-onscreen Fail igt@kms_cursor_crc@cursor-128x128-random Fail igt@kms_cursor_crc@cursor-128x128-rapid-movement Fail igt@kms_cursor_crc@cursor-128x128-sliding Fail igt@kms_cursor_crc@cursor-128x128-suspend Fail igt@kms_cursor_crc@cursor-256x256-dpms Fail igt@kms_cursor_crc@cursor-256x256-offscreen Fail igt@kms_cursor_crc@cursor-256x256-onscreen Fail igt@kms_cursor_crc@cursor-256x256-random Fail igt@kms_cursor_crc@cursor-256x256-rapid-movement Fail igt@kms_cursor_crc@cursor-256x256-sliding Fail igt@kms_cursor_crc@cursor-256x256-suspend Fail igt@kms_cursor_crc@cursor-64x64-dpms Fail igt@kms_cursor_crc@cursor-64x64-offscreen Fail igt@kms_cursor_crc@cursor-64x64-onscreen Fail igt@kms_cursor_crc@cursor-64x64-random Fail igt@kms_cursor_crc@cursor-64x64-rapid-movement Fail igt@kms_cursor_crc@cursor-64x64-sliding Fail igt@kms_cursor_crc@cursor-64x64-suspend Fail igt@kms_cursor_crc@cursor-size-change Fail e.g igt@kms_cursor_crc@cursor-256x256-rapid-movement
(kms_cursor_crc:21732) igt-kms-CRITICAL: Test assertion failure function igt_primary_plane_commit_legacy, file igt_kms.c:2229:
(kms_cursor_crc:21732) igt-kms-CRITICAL: Failed assertion: ret == 0
(kms_cursor_crc:21732) igt-kms-CRITICAL: Last errno: 22, Invalid argument
(kms_cursor_crc:21732) igt-kms-CRITICAL: error: -22 != 0
Subtest cursor-256x256-rapid-movement failed.
**** DEBUG ****
(kms_cursor_crc:21732) DEBUG: Test requirement passed: cursor_w <= data->cursor_max_w && cursor_h <= data->cursor_max_h
(kms_cursor_crc:21732) igt-kms-DEBUG: display: HDMI-A-1: set_pipe(A)
(kms_cursor_crc:21732) igt-kms-DEBUG: display: HDMI-A-1: Selecting pipe A
(kms_cursor_crc:21732) igt-kms-DEBUG: display: A.2: plane_set_fb(0)
(kms_cursor_crc:21732) igt-fb-DEBUG: igt_create_fb_with_bo_size(width=1920, height=1080, format=0x34325258, tiling=0x0, size=0)
(kms_cursor_crc:21732) igt-fb-DEBUG: igt_create_fb_with_bo_size(handle=2, pitch=7680)
(kms_cursor_crc:21732) igt-kms-DEBUG: display: A.0: plane_set_fb(127)
(kms_cursor_crc:21732) igt-kms-DEBUG: display: commit {
(kms_cursor_crc:21732) igt-kms-DEBUG: display: HDMI-A-1: Selecting pipe A
(kms_cursor_crc:21732) igt-kms-DEBUG: display: HDMI-A-1: SetCrtc pipe A, fb 127, src (0, 0), mode 1920x1080
(kms_cursor_crc:21732) igt-kms-CRITICAL: Test assertion failure function igt_primary_plane_commit_legacy, file igt_kms.c:2229:
(kms_cursor_crc:21732) igt-kms-CRITICAL: Failed assertion: ret == 0
(kms_cursor_crc:21732) igt-kms-CRITICAL: Last errno: 22, Invalid argument
(kms_cursor_crc:21732) igt-kms-CRITICAL: error: -22 != 0
and igt@kms_cursor_crc@cursor-256x256-offscreen
(kms_cursor_crc:21709) igt-kms-CRITICAL: Test assertion failure function igt_primary_plane_commit_legacy, file igt_kms.c:2229:
(kms_cursor_crc:21709) igt-kms-CRITICAL: Failed assertion: ret == 0
(kms_cursor_crc:21709) igt-kms-CRITICAL: Last errno: 22, Invalid argument
(kms_cursor_crc:21709) igt-kms-CRITICAL: error: -22 != 0
Subtest cursor-256x256-offscreen failed.
**** DEBUG ****
(kms_cursor_crc:21709) DEBUG: Test requirement passed: cursor_w <= data->cursor_max_w && cursor_h <= data->cursor_max_h
(kms_cursor_crc:21709) igt-kms-DEBUG: display: HDMI-A-1: set_pipe(A)
(kms_cursor_crc:21709) igt-kms-DEBUG: display: HDMI-A-1: Selecting pipe A
(kms_cursor_crc:21709) igt-kms-DEBUG: display: A.2: plane_set_fb(0)
(kms_cursor_crc:21709) igt-fb-DEBUG: igt_create_fb_with_bo_size(width=1920, height=1080, format=0x34325258, tiling=0x0, size=0)
(kms_cursor_crc:21709) igt-fb-DEBUG: igt_create_fb_with_bo_size(handle=2, pitch=7680)
(kms_cursor_crc:21709) igt-kms-DEBUG: display: A.0: plane_set_fb(127)
(kms_cursor_crc:21709) igt-kms-DEBUG: display: commit {
(kms_cursor_crc:21709) igt-kms-DEBUG: display: HDMI-A-1: Selecting pipe A
(kms_cursor_crc:21709) igt-kms-DEBUG: display: HDMI-A-1: SetCrtc pipe A, fb 127, src (0, 0), mode 1920x1080
(kms_cursor_crc:21709) igt-kms-CRITICAL: Test assertion failure function igt_primary_plane_commit_legacy, file igt_kms.c:2229:
(kms_cursor_crc:21709) igt-kms-CRITICAL: Failed assertion: ret == 0
(kms_cursor_crc:21709) igt-kms-CRITICAL: Last errno: 22, Invalid argument
(kms_cursor_crc:21709) igt-kms-CRITICAL: error: -22 != 0
**** END ****
This seems to be the culprit: "[drm:intel_crtc_atomic_check] No valid intermediate pipe watermarks are possible" So quite likely a watermark issue. Created attachment 130778 [details] [review] relax watermark calculations Hey, Could be 2 things, either no intermediate values can be found while we modeset or we're using the wrong watermarks to calculate intermediate values for. Does the attached patch fix things? If so could you see which of the 2 hunk in it? Luis can you help to test the patch included to see if this fixes the issue... (In reply to Maarten Lankhorst from comment #5) > Created attachment 130778 [details] [review] [review] > relax watermark calculations > > Hey, > > Could be 2 things, either no intermediate values can be found while we > modeset or we're using the wrong watermarks to calculate intermediate values > for. > > Does the attached patch fix things? If so could you see which of the 2 hunk > in it? Hi Maarten this path is included in the latest drm-tip commits ? because with the latest commit the following test cases failed on BSW testlist ====================================== igt@kms_cursor_crc@cursor-64x64-onscreen igt@kms_cursor_crc@cursor-128x128-random igt@kms_cursor_crc@cursor-256x256-suspend igt@kms_cursor_crc@cursor-64x64-suspend igt@kms_cursor_crc@cursor-128x128-onscreen igt@kms_cursor_crc@cursor-256x256-onscreen igt@kms_cursor_crc@cursor-128x128-suspend igt@kms_cursor_crc@cursor-256x256-random kernel =================================================== commit 4aa1d46d3b24bbe545cdf7cbd407c18f5cd5e43d Author: Daniel Vetter <daniel.vetter@ffwll.ch> AuthorDate: Wed May 31 10:59:05 2017 +0200 Commit: Daniel Vetter <daniel.vetter@ffwll.ch> CommitDate: Wed May 31 10:59:05 2017 +0200 drm-tip: 2017y-05m-31d-08h-58m-36s UTC integration manifest I've seen a failure on BSW which is really an expected failure. The cursor cannot be used at negative coordinates on pipe C. Patch for IGT on https://patchwork.freedesktop.org/series/25759/ That should hopefully be enough to fix BSW. Should be fixed now for bsw, can you verify? Also is HSW still affected? commit 6fcc8e8b247661c7950b998e0b95141ffbd6b833 Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Date: Wed Jun 14 10:17:31 2017 +0200 tests/kms_cursor_crc: Fix the cursor tests to work on CHV (In reply to Maarten Lankhorst from comment #9) > Should be fixed now for bsw, can you verify? > > Also is HSW still affected? > > commit 6fcc8e8b247661c7950b998e0b95141ffbd6b833 > Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Date: Wed Jun 14 10:17:31 2017 +0200 > > tests/kms_cursor_crc: Fix the cursor tests to work on CHV The tests are passed on HSW now with the following configuration: Software Configuration: ====================================== Component: drm tag: libdrm-2.4.81-24-g3095cc8 commit: 3095cc8eaba1aa87ad38c04ae2b1eabe30f7e16c Component: cairo tag: 1.15.6-2-g57b4050 commit: 57b40507dda3f58dfc8635548d606b86dc7bcf51 Component: intel-gpu-tools tag: intel-gpu-tools-1.19-57-g6fcc8e8 commit: 6fcc8e8b247661c7950b998e0b95141ffbd6b833 Component: piglit tag: piglit-v1 commit: c8f4fd9eeb298a2ef0855927f22634f794ef3eff Hardware Configuration: ====================================== platform : Haswell motherboard model : Haswell manufacturer : IntelCorp. cpu : Intel® Core™ i5-4250U Processor gpu : Intel® HD Graphics 5000 max memory ram : 16 GB cpu core : 2 (In reply to Maarten Lankhorst from comment #9) > Should be fixed now for bsw, can you verify? > > Also is HSW still affected? > > commit 6fcc8e8b247661c7950b998e0b95141ffbd6b833 > Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Date: Wed Jun 14 10:17:31 2017 +0200 > > tests/kms_cursor_crc: Fix the cursor tests to work on CHV There are two tests that keep failing on BSW with the following configuration: Tests failed ====================================== igt@kms_cursor_crc@cursor-64x64-suspend igt@kms_cursor_crc@cursor-256x256-suspend Software Configuration: ====================================== Component: drm tag: libdrm-2.4.81-24-g3095cc8 commit: 3095cc8eaba1aa87ad38c04ae2b1eabe30f7e16c Component: cairo tag: 1.15.6-2-g57b4050 commit: 57b40507dda3f58dfc8635548d606b86dc7bcf51 Component: intel-gpu-tools tag: intel-gpu-tools-1.19-57-g6fcc8e8 commit: 6fcc8e8b247661c7950b998e0b95141ffbd6b833 Component: piglit tag: piglit-v1 commit: c8f4fd9eeb298a2ef0855927f22634f794ef3eff Hardware Configuration: ====================================== platform : Braswell motherboard model : Braswell manufacturer : IntelCorp. cpu : Intel® Pentium® Processor N3700 gpu : Intel® HD Graphics max memory ram : 8 GB cpu core : 4 All the other test had passed. What is failing now exactly? Created attachment 132677 [details]
dmesg log
Created attachment 132678 [details]
kern log BSW
Created attachment 132679 [details]
Test Outputs
Adding the information. Sorry for the delay.
(In reply to Elizabeth from comment #15) > Created attachment 132679 [details] > Test Outputs > > Adding the information. Sorry for the delay. After the last process: rtcwake: assuming RTC uses UTC ... rtcwake: wakeup from "mem" using /dev/rtc0 at Thu Jul 13 19:53:42 2017 The BSW lost communication. Might be a different cause now if suspend is failing, something for Ville? What I do see in dmesg is the below: [ 593.079757] [drm:vlv_suspend_complete [i915]] *ERROR* timeout waiting for GT wells to go off [ 593.079770] WARN_ON((I915_READ(VLV_GTLC_WAKE_CTRL) & mask) != mask); The original bug is closed, please open a new bug for the CDCLK dmesg error on bsw. :) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.