Bug 97336

Summary:	with xkbcomp from git, trailing "any"s are seen as "none"s
Product:	xkeyboard-config	Reporter:	Benno Schulenberg <bensberg>
Component:	General	Assignee:	xkb
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	caslav.ilic, dsegan, matej
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	adjusting two layouts so they will work with a newer xkbcomp cleaning up some clutter being totally precise removes an explicit key type for a German layout too

Description Benno Schulenberg 2016-08-13 20:04:07 UTC

Created attachment 125772 [details] [review]
adjusting two layouts so they will work with a newer xkbcomp

With xkbcomp from git, an "any" (NoSymbol) in the upper levels of a key definition is understood as "none" (VoidSymbol) when the layout specifies a keytype explicitly -- a keytype that has more levels than the layout actually defines.  Avoid this by not specifying the keytype -- it doesn't make sense to say that the keys are of type FOUR_LEVEL and then define only two levels and leave the upper two levels blank (because they are to be inherited from an included file).  See bug #97332.  Attached patch fixes this.

Comment 1 Benno Schulenberg 2016-08-14 08:07:05 UTC

Created attachment 125775 [details] [review]
cleaning up some clutter

Comment 2 Benno Schulenberg 2016-08-14 08:09:14 UTC

Created attachment 125776 [details] [review]
being totally precise

Comment 3 Chusslove Illich 2016-08-21 20:39:12 UTC

Seems fine to me, if that's what corresponds to the new semantics. At least for me the patched layout appears to behave no different than the old one.

One little thing about the NoSymbol identifiers, just for the record. Originally these were intended to remove any underlying symbol from previously included sections. This can be seen in *alternatequotes variants, where without AC02 and AC03 keys would end up having the same symbols on 3rd and 4th levels. However, testing now the non-patched layout, NoSymbol does not appear to do anything. Can't remember if they ever worked as intended, but in any case no harm removing them now. (And *alternatequotes should probably just switch 3rd and 4th levels, rather than try to remove anything.)

Comment 4 Sergey V. Udaltsov 2016-09-13 23:33:13 UTC

applied #2 and #3. Could you please clean #1 for the current git? Thank you for the patches!

Comment 5 Benno Schulenberg 2016-09-14 07:23:13 UTC

Ah.  The patch in bug #97332 shouldn't have been applied, I should have obsoleted it -- #1 was a better version of that patch.

Never mind, updated patch coming up.  (But in future, please don't apply any patches when something in a series doesn't apply cleanly.  Makes my life easier.)

Comment 6 Benno Schulenberg 2016-09-14 07:24:15 UTC

Created attachment 126509 [details] [review]
removes an explicit key type for a German layout too

Comment 7 Sergey V. Udaltsov 2016-09-14 23:21:56 UTC

Thank you, pushed!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.