Bug 96257

Summary: Check for host-prefixed cpp first in XORG_PROG_RAWCPP macro
Product: xorg Reporter: Marvin Schmidt <marvin_schmidt>
Component: Build/ModularAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium Keywords: patch
Version: git   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Use AC_PATH_TOOL instead of AC_PATH_PROGS to find `cpp` executable in XORG_PROG_RAWCPP none

Description Marvin Schmidt 2016-05-28 09:40:59 UTC 
Created attachment 124144 [details] [review]
Use AC_PATH_TOOL instead of AC_PATH_PROGS to find `cpp` executable in XORG_PROG_RAWCPP

On Exherbo we prohibit the use of unprefixed toolchain programs like gcc, ld, pkg-config etc. in our package manager environment to detect misuses of them and avoid running into problems when cross-compiling programs. The XORG_PROG_RAWCPP macro currently tries to use `cpp` and thus triggers an error. In order to prefer the host-prefixed version of cpp the attached patch changes the macro to find the cpp program to use AC_PATH_TOOL. This will check for `$host-cpp` first and if not found for `cpp`.
Comment 1 Timo Gurr 2018-03-08 17:02:05 UTC 
Is there any problem with the patch? It's been two years and the patch is still required in the latest version released just a few days ago. Please advise.
Comment 2 Alan Coopersmith 2018-03-24 18:59:50 UTC 
There's no problem I can see with the patch other than it's stuck in bugzilla
and no one ever looks here.

I've sent it on to the xorg-devel mailing list for review as suggested in
https://www.x.org/wiki/Development/Documentation/SubmittingPatches/
That tends to have a better chance of getting attention currently.

Hopefully the upcoming move to gitlab will improve things when you can just
submit a pull request through the easy interface instead of the mailing list.
Comment 3 Alan Coopersmith 2018-03-30 22:51:34 UTC 
Pushed to git master:
To ssh://git.freedesktop.org/git/xorg/util/macros
   771b773..bd66ce3  master -> master

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.