Bug 95296

Summary: nir_lower_double_packing.c:79:4: error: void function 'lower_double_pack_impl' should not return a value [-Wreturn-type]
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact: mesa-dev
Severity: normal    
Priority: medium CC: cwabbott0, idr, jason
Version: gitKeywords: bisected, regression
Hardware: x86-64 (AMD64)   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2016-05-06 08:29:48 UTC 
mesa: bd326c229c528a214c9fda705e7a961cfa49ac9e (master 11.3.0-devel)

  CC       nir/nir_libnir_la-nir_lower_double_packing.lo
nir/nir_lower_double_packing.c:79:4: error: void function 'lower_double_pack_impl' should not return a value [-Wreturn-type]
   return true;
   ^      ~~~~


Build error introduced by this commit.

commit 450c0613627d5a472fcf1122c15b66988abfb372
Author: Jason Ekstrand <jason.ekstrand@intel.com>
Date:   Wed Apr 13 16:26:57 2016 -0700

    nir/lower_double_pack: fixup for new nir_foreach_block()
    
    Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
    Reviewed-by: Connor Abbott <cwabbott0@gmail.com>
    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Comment 1 Jose Fonseca 2016-05-06 11:04:23 UTC 
GCC (at least 5.2.1) also throws an warning...

src/compiler/nir/nir_lower_double_packing.c: In function ‘lower_double_pack_impl’:
src/compiler/nir/nir_lower_double_packing.c:79:11: warning: ‘return’ with a value, in function returning void
    return true;
           ^

Don't older GCC versions warn?


I've took the liberty of pushing fix 8ae78f7d2828778a386ed1737f17add69eb035a9
Comment 2 Jason Ekstrand 2016-05-06 16:01:03 UTC 
(In reply to Jose Fonseca from comment #1)
> GCC (at least 5.2.1) also throws an warning...
> 
> src/compiler/nir/nir_lower_double_packing.c: In function
> ‘lower_double_pack_impl’:
> src/compiler/nir/nir_lower_double_packing.c:79:11: warning: ‘return’ with a
> value, in function returning void
>     return true;
>            ^
> 
> Don't older GCC versions warn?
> 
> 
> I've took the liberty of pushing fix 8ae78f7d2828778a386ed1737f17add69eb035a9

Thanks!  Patch looks good to me.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.