Bug 94198

My first guess would be that it's working on an incomplete texture and one of the cube faces is missing.  Either that, or it's just botching the silly cube face -> gl_texture_image -> cube face conversion we have to do all over the place.  But I haven't looked at it in any sort of detail.

Looks like what's happening is that the view_tex_obj in meta_copy_image effectively becomes an incomplete cubemap texture, and the intel_texture_view logic isn't ready for that.

   _mesa_GenTextures(1, view_tex_name);
   view_tex_obj = _mesa_lookup_texture(ctx, *view_tex_name);
   view_tex_obj->Target = tex_obj->Target;
   view_tex_obj->TargetIndex = tex_obj->TargetIndex;

   *view_tex_image = _mesa_get_tex_image(ctx, view_tex_obj, tex_obj->Target, 0);
   _mesa_init_teximage_fields(*view_tex_image);

   ctx->Driver.TextureView(view_tex_obj)

but only one image of the view_tex_obj was initialized. intel_texture_view then does:

   const int numFaces = _mesa_num_tex_faces(texObj->Target);
   for (face = 0; face < numFaces; face++) {
      for (level = 0; level < numLevels; level++) {
         struct gl_texture_image *image = texObj->Image[face][level];
         struct intel_texture_image *intel_image = intel_texture_image(image);

         intel_miptree_reference(&intel_image->mt, intel_orig_tex->mt);

but while the Target is GL_TEXTURE_CUBE_MAP (and thus there are 6 faces), only one of them [the first] has been initialized. I guess the solution is to pre-initialize all of the faces in meta_copy_image.c:make_view?

Created attachment 121820 [details] [review]
patch that doesn't work

I tried to fix this, and while this resolves the crash, the test in question still fails.

For the record, the relevant enablement patches should be pushed now. Just need to run dEQP with MESA_EXTENSION_OVERRIDE=GL_EXT_copy_image which should allow the test in question to run.

My recent copy image series (0f0f357b77123544ecc6c3cf50ac87b68e798d43 and earlier) ported this to BLORP on Gen6+.  We never use the meta code that crashes.

It might still be a problem on Gen4-5, but these are also dEQP-GLES31 tests that will probably never run on Gen4-5.  We should eventually shore up Gen4-5 support, but it's probably best to track that effort separately.

Marking as fixed.