| Summary: | [PATCH] Fix build failure caused by missing include | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Eric <eh275> |
| Component: | core | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | D-Bus Maintainers <dbus> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | other | ||
| Whiteboard: | review? | ||
| i915 platform: | i915 features: | ||
| Attachments: |
Patch including <dbus/dbus.h> to fix compile failure
Only compile test-bus-launch-helper, etc. if embedded tests are enabled |
||
|
Description
Eric
2016-02-11 17:16:28 UTC
What configuration (cmake options) are you using to build D-Bus? What platform is this on? From the mentions of "C_" in your log I'm guessing Windows. If you're building on Windows, then it doesn't make sense to compile test-bus-launch-helper. (In reply to Simon McVittie from comment #1) > From the mentions of "C_" in your log I'm guessing Windows. If you're > building on Windows, then it doesn't make sense to compile > test-bus-launch-helper. Oh, I see you're the same person cross-compiling for Android on Windows... I'm amazed that works, tbh. The issue here seems to be that in the recommended Autotools build system, test-bus-launch-helper (and some other stuff) is built if we are compiling for non-Windows *and* "embedded tests" (intrusive tests that insert extra crap into the binaries) are enabled; but in the CMake build system, test-bus-launch-helper is built whenever we are compiling for non-Windows, even if "embedded tests" are disabled. The CMake build system is basically there because some developers on Windows want to use Microsoft Visual C++ as their C compiler, in order to use its built-in debugger. It can also compile for GNU/Linux on GNU/Linux just so that it's easier to stop it bit-rotting, but it isn't really intended for more complex situations like non-GNU Unixes, and many combinations of options probably don't work. Comment on attachment 121680 [details] [review] Patch including <dbus/dbus.h> to fix compile failure Review of attachment 121680 [details] [review]: ----------------------------------------------------------------- Strictly speaking this file should always have done this, so I'm applying it, but please don't interpret that as the CMake build system being fully-supported. Patch applied for 1.11.2, thanks. Leaving this bug open while I clean up the build for those tests. Created attachment 121692 [details] [review] Only compile test-bus-launch-helper, etc. if embedded tests are enabled These source files are specific to the embedded tests and make no sense otherwise. Also remove a comment in the CMake build system about fixing the build of the activation helper on Windows: the activation helper is Unix-specific and always will be, since it relies on Unix setuid to function. (assigning to myself to remind me that I can't be the reviewer for my own code) (In reply to Simon McVittie from comment #5) > Only compile test-bus-launch-helper, etc. if embedded tests are enabled Applied unreviewed for 1.11.6. I assume that any maintainer who objected would have said something by now. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.