Bug 93696

Yes, the calculation seems incorrect, it should rather use amount of uniformremaptable entries + implicit uniforms.

I did not notice this regression because on HSW this test has always failed.

It is a new reason for fail. We no fail to link:

 <InfoLog>error: count of uniform locations &gt;= MAX_UNIFORM_LOCATIONS(196608 &gt;= 98304)</InfoLog>

 <InfoLog>error: count of uniform locations &gt;= MAX_UNIFORM_LOCATIONS(98304 &gt;= 98304)</InfoLog>

Is mesa: git@4985159ad6 calculating correct?

(In reply to Marta Löfstedt from comment #3)
> It is a new reason for fail. We no fail to link:
> 
>  <InfoLog>error: count of uniform locations &gt;=
> MAX_UNIFORM_LOCATIONS(196608 &gt;= 98304)</InfoLog>
> 
>  <InfoLog>error: count of uniform locations &gt;=
> MAX_UNIFORM_LOCATIONS(98304 &gt;= 98304)</InfoLog>
> 
> Is mesa: git@4985159ad6 calculating correct?

no the calculation is wrong (only with some cases though) sorry for this

Fix available here:
http://cgit.freedesktop.org/~tpalli/mesa/log/?h=fixing_uniforms

Will clean this up and send to mesa-dev list soon.

I can't reproduce this issue with:
http://patchwork.freedesktop.org/patch/70656/

commit 4475d8f9169195baefa893b9b147fe20414cda7c
Author: Tapani Pälli <tapani.palli@intel.com>
Date:   Fri Jan 15 13:11:20 2016 +0200

    glsl: move uniform calculation to link_uniforms
    
    Patch moves uniform calculation to happen during link_uniforms, this
    is possible with help of UniformRemapTable that has all the reserved
    locations.
    
    Location assignment for implicit locations is changed so that we
    utilize also the 'holes' that explicit uniform location assignment
    might have left in UniformRemapTable, this makes it possible to fit
    more uniforms as previously we were lazy here and wasting space.
    
    Fixes following CTS tests:
       ES31-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max
       ES31-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max-array
    
    v2: code cleanups, increment NumUniformRemapTable correctly, fix
        find_empty_block to work properly and add some more comments.
    
    Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
    Reviewed-by: Marta Lofstedt <marta.lofstedt@intel.com>

I've reverted the fix as it had bugs, reopening.

commit 65dfb3048e8291675ca33581aeff8921f7ea509d
Author: Plamena Manolova <plamena.manolova@intel.com>
Date:   Thu Feb 11 15:00:02 2016 +0200

    compiler/glsl: Fix uniform location counting.
    
    This patch moves the calculation of current uniforms to
    link_uniforms, which makes use of UniformRemapTable which
    stores all the reserved uniform locations.
    
    Location assignment for implicit uniforms now tries to use
    any gaps left in the table after the location assignment
    for explicit uniforms. This gives us more space to store more
    uniforms.
    
    Patch is based on earlier patch with following changes/additions:
    
       1: Move the counting of explicit locations to
          check_explicit_uniform_locations and then pass
          the number to link_assign_uniform_locations.
       2: Count the number of empty slots in UniformRemapTable
          and store them in a list_head.
       3: Try to find an empty slot for implicit locations from
          the list, if that fails resize UniformRemapTable.
    
    Fixes following CTS tests:
       ES31-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max
       ES31-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max-array
    
    Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
    Signed-off-by: Plamena Manolova <plamena.manolova@intel.com>
    Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93696