Bug 93333

Summary: [regression, HSW, IVB] spec.arb_compute_shader.execution.atomic-counter broken on 32 bit platforms
Product: piglit Reporter: Mark Janes <mark.a.janes>
Component: infrastructureAssignee: Kenneth Graunke <kenneth>
Status: RESOLVED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: blocker    
Priority: medium CC: mark.a.janes
Version: unspecified   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 96253    

Description Mark Janes 2015-12-10 20:03:33 UTC 
d04612b60d98ff785646affaffc3d7243deecb74 regressed this test on 32 bit hsw/ivb:

Author:     Jordan Justen <jordan.l.justen@intel.com>
AuthorDate: Wed Sep 2 15:47:33 2015 -0700
Commit:     Jordan Justen <jordan.l.justen@intel.com>
CommitDate: Wed Dec 9 23:50:38 2015 -0800

    i965: Enable ARB_compute_shader extension on supported hardware
    
    Enable ARB_compute_shader on gen7+, on hardware that supports the
    OpenGL 4.3 requirements of a local group size of 1024.
    
    With SIMD16 support, this is limited to Ivy Bridge and Haswell.
    
    Broadwell will work with a local group size up to 896 on SIMD16
    meaning programs that use this size or lower should run when setting
    MESA_EXTENSION_OVERRIDE=GL_ARB_compute_shader.
    
    Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
    Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
    Reviewed-by: Kristian Høgsberg <krh@bitplanet.net>


Test output:
/tmp/build_root/m32/lib/piglit/bin/shader_runner /tmp/build_root/m32/lib/piglit/tests/spec/arb_compute_shader/execution/atomic-counter.shader_test -auto
piglit: debug: Requested an OpenGL 3.2 Core Context, and received a matching 3.3 context

Atomic counter 1 test failed: Reference == Observed
  Reference: 2147483647
  Observed:  4294966784
Comment 1 Kenneth Graunke 2016-06-01 05:04:12 UTC 
I believe this is a bug in shader_runner.  I've posted a patch to the piglit mailing list:

http://mid.gmane.org/20160601050207.1542-1-kenneth@whitecape.org

Note that the observed value matches the test, but the /expected/ value (i.e. the one written directly in the script) is bogus.  Seems to be scanf fail.
Comment 2 Mark Janes 2016-06-03 22:36:47 UTC 
*** Bug 96298 has been marked as a duplicate of this bug. ***
Comment 3 Kenneth Graunke 2016-06-06 18:36:48 UTC 
Fixed in Piglit by:

commit bca09cba2acf44405f433162755bd151bc850442
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Tue May 31 21:50:48 2016 -0700

    shader_runner: Use %u in "probe atomic counter" scanf calls.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.