Bug 92325

I just started seeing an assertion failure in the gl-1.0-no-op-paths test on i915 (G33, specifically).  I bisected to:

commit c277fa394087272c79d65fc308d268fc768b91e5
Author: Brian Paul <brianp@vmware.com>
Date:   Wed Sep 30 11:29:13 2015 -0600

    mesa: consolidate texture binding code
    
    Before, we were doing the actual _mesa_reference_texobj() call and
    ctx->Driver.BindTexture() and misc housekeeping in three different
    places.  This consolidates the common code in a new bind_texture()
    function.
    
    Reviewed-by: Tapani Pälli <tapani.palli@intel.com>

$ gdb --args bin/gl-1.0-no-op-paths -auto -fbo
GNU gdb (GDB) Fedora 7.9.1-17.fc22
Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-redhat-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from bin/gl-1.0-no-op-paths...done.
(gdb) r
Starting program: /home/idr/devel/graphics/piglit/bin/gl-1.0-no-op-paths -auto -fbo
Missing separate debuginfos, use: dnf debuginfo-install glibc-2.21-7.fc22.x86_64
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
gl-1.0-no-op-paths: i915_vtbl.c:780: i915_update_draw_buffer: Assertion `intel_rb_format(irbStencil) == MESA_FORMAT_Z24_UNORM_S8_UINT' failed.

Program received signal SIGABRT, Aborted.
0x00007ffff5af49c8 in raise () from /lib64/libc.so.6
Missing separate debuginfos, use: dnf debuginfo-install bzip2-libs-1.0.6-14.fc22.x86_64 elfutils-libelf-0.163-3.fc22.x86_64 elfutils-libs-0.163-3.fc22.x86_64 expat-2.1.0-10.fc22.x86_64 libattr-2.4.47-9.fc22.x86_64 libcap-2.24-7.fc22.x86_64 libgcc-5.1.1-4.fc22.x86_64 libpng-1.6.16-3.fc22.x86_64 libstdc++-5.1.1-4.fc22.x86_64 systemd-libs-219-24.fc22.x86_64 waffle-1.5.0-3.fc22.x86_64 xz-libs-5.2.0-2.fc22.x86_64 zlib-1.2.8-7.fc22.x86_64
(gdb) bt
#0  0x00007ffff5af49c8 in raise () from /lib64/libc.so.6
#1  0x00007ffff5af665a in abort () from /lib64/libc.so.6
#2  0x00007ffff5aed187 in __assert_fail_base () from /lib64/libc.so.6
#3  0x00007ffff5aed232 in __assert_fail () from /lib64/libc.so.6
#4  0x00007ffff1c05b5e in i915_update_draw_buffer (intel=0x7ffff7f8b040) at i915_vtbl.c:780
#5  0x00007ffff1c0c4c1 in intel_draw_buffer (ctx=0x7ffff7f8b040) at intel_buffers.h:46
#6  0x00007ffff1c0d376 in intel_render_texture (ctx=0x7ffff7f8b040, fb=0x7e8300, att=0x7e84d0) at intel_fbo.c:522
#7  0x00007ffff19a97f2 in _mesa_update_texture_renderbuffer (ctx=ctx@entry=0x7ffff7f8b040, fb=0x7e8300, att=att@entry=0x7e84d0)
    at main/fbobject.c:456
#8  0x00007ffff1a56eff in check_rtt_cb (key=<optimized out>, data=0x7e8300, userData=<optimized out>) at main/teximage.c:2568
#9  0x00007ffff1a18dc6 in _mesa_HashWalk (table=0x62f840, callback=callback@entry=0x7ffff1a56e86 <check_rtt_cb>, 
    userData=userData@entry=0x7fffffffd9d0) at main/hash.c:419
#10 0x00007ffff1a5aa3f in _mesa_update_fbo_texture (ctx=ctx@entry=0x7ffff7f8b040, texObj=texObj@entry=0x80e390, 
    face=face@entry=0, level=<optimized out>) at main/teximage.c:2596
#11 0x00007ffff1a5b37d in teximage (ctx=0x7ffff7f8b040, compressed=compressed@entry=0 '\000', dims=dims@entry=2, target=3553, 
    level=<optimized out>, internalFormat=6408, width=4, height=4, depth=1, border=0, format=6408, type=5121, imageSize=0, 
    pixels=0x7fffffffdb40) at main/teximage.c:2986
#12 0x00007ffff1a5bf09 in _mesa_TexImage2D (target=<optimized out>, level=<optimized out>, internalFormat=<optimized out>, 
    width=<optimized out>, height=<optimized out>, border=<optimized out>, format=6408, type=5121, pixels=0x7fffffffdb40)
    at main/teximage.c:3018
#13 0x0000000000401767 in set_path_state (paths=TEXTURE, states=ALWAYS_PASS) at tests/spec/gl-1.0/no-op-paths.c:214
#14 0x0000000000401832 in piglit_display () at tests/spec/gl-1.0/no-op-paths.c:252
#15 0x00007ffff7b42dad in run_test (gl_fw=0x615c20, argc=1, argv=0x7fffffffddb8)
    at tests/util/piglit-framework-gl/piglit_fbo_framework.c:52
#16 0x00007ffff7b295d7 in piglit_gl_test_run (argc=1, argv=0x7fffffffddb8, config=0x7fffffffdc80)
    at tests/util/piglit-framework-gl.c:199
#17 0x0000000000401240 in main (argc=1, argv=0x7fffffffddb8) at tests/spec/gl-1.0/no-op-paths.c:57
(gdb) up
#1  0x00007ffff5af665a in abort () from /lib64/libc.so.6
(gdb) 
#2  0x00007ffff5aed187 in __assert_fail_base () from /lib64/libc.so.6
(gdb) 
#3  0x00007ffff5aed232 in __assert_fail () from /lib64/libc.so.6
(gdb) 
#4  0x00007ffff1c05b5e in i915_update_draw_buffer (intel=0x7ffff7f8b040) at i915_vtbl.c:780
780	      assert(intel_rb_format(irbStencil) == MESA_FORMAT_Z24_UNORM_S8_UINT);
(gdb) print irbStencil->Base.Base.Format
$1 = MESA_FORMAT_B8G8R8A8_UNORM