Bug 91859

Summary:	Assignment instead of check for equality in assert: asyncns_setuserdata, asyncns_getuserdata
Product:	libasyncns	Reporter:	Olof Sivertsson <osivertsson+bugs.freedesktop.org>
Component:	general	Assignee:	Lennart Poettering <lennart>
Status:	NEW ---	QA Contact:	Lennart Poettering <lennart>
Severity:	trivial
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Olof Sivertsson 2015-09-03 08:09:46 UTC

Bug applies to libasyncns release 0.8 and current git revision 68cd5a.

Both asyncns_setuserdata(...) and asyncns_getuserdata(...) contain the following line:

  assert(q->asyncns = asyncns);


I believe this should not be assignment, but a check for equality, as is correctly done already in asyncns_isdone(...):

  assert(q->asyncns == asyncns);


Thank you for a very useful and fine piece of free software in libasyncns!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.