Bug 906

Summary: CVS trunk does not compile with |#define OptimizedCDebugFlags -g -DDEBUG|
Product: xorg Reporter: Roland Mainz <roland.mainz>
Component: Build/MonolithicAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED WONTFIX QA Contact:
Severity: major    
Priority: high CC: ajax, eich, kem, roland.mainz, torrey
Version: gitKeywords: janitor
Hardware: PowerPC   
OS: Mac OS X (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
s/pointer/char */
none
orphaned code removal none

Description Roland Mainz 2004-07-20 14:14:13 UTC
2004-07-20-trunk on Darwin/PPC, the source tree does not compile when I set
|#define OptimizedCDebugFlags -g -DDEBUG| in hosts.def and darwin.def.
the tree permanently fails at various points.

Example:
-- snip --
rm -f dixfonts.o
/usr/bin/cc -c -g -DDEBUG -DDEBUG_gisburn -Wall -Wpointer-arith -no-cpp-precomp
-UNEED_SCREEN_REGIONS     -I../include -I../../../ex
ports/include/X11 -I../../../include/fonts
-I../../../include/extensions               -I../../../programs/Xserver/Xext
-I../../../p
rograms/Xserver/lbx  -I../../.. -I../../../exports/include   -D__powerpc__
-D__DARWIN__                                 -DNO_ALLOCA 
-DCSRG_BASED  -DSHAPE  -DXKB -DLBX -DXAPPGROUP  -DXCSECURITY -DTOGCUP  
-DXF86BIGFONT    -DPIXPRIV -DPANORAMIX   -DRENDER -DRANDR   
        -DXFIXES -DDAMAGE -DAVOID_GLYPHBLT -DPIXPRIV
-DSINGLEDEPTH                               -DXvExtension                      
        
-DXFree86Server                                                               
-DXvMCExtension                             
        -DSMART_SCHEDULE                                -DBUILDDEBUG
-DXResExtension                            -DX_BYTE_ORDER=X_BIG
_ENDIAN                                 -DXORG_VERSION_CURRENT="(((6) *
10000000) + ((7) * 100000) + ((0) * 1000) + 0)" -DNDEBUG    
    -DVENDOR_STRING=\""The X.Org Foundation"\" -DVENDOR_RELEASE="(((6) *
10000000) + ((7) * 100000) + ((0) * 1000) + 0)" -DDARWIN_WI
TH_QUARTZ -DROOTLESS  dixfonts.c
dixfonts.c:2179: warning: return type defaults to `int'
dixfonts.c: In function `dump_char_ascii':
dixfonts.c:2192: warning: pointer of type `void *' used in arithmetic
dixfonts.c:2197: warning: pointer of type `void *' used in arithmetic
dixfonts.c:2197: warning: dereferencing `void *' pointer
dixfonts.c:2197: error: void value not ignored as it ought to be
make[5]: *** [dixfonts.o] Error 1
make[4]: *** [dix] Error 2
-- snip --

Next failure is:
-- snip --
rm -f fbtrap.o
/usr/bin/cc -c -g -DDEBUG -DDEBUG_gisburn -Wall -Wpointer-arith -no-cpp-precomp
-UNEED_SCREEN_REGIONS     -I../../../programs/Xserver/fb
-I../../../programs/Xserver/mi -I../../../programs/Xserver/include          
-I../../../exports/include/X11          -I../../../include/fonts
-I../../../programs/Xserver/hw/xfree86/common         
-I../../../programs/Xserver/render -I../../../include/extensions
-I../../../programs/Xserver/Xext  -I../../.. -I../../../exports/include  
-D__powerpc__ -D__DARWIN__                                 -DNO_ALLOCA
-DCSRG_BASED  -DSHAPE  -DXKB -DLBX -DXAPPGROUP  -DXCSECURITY -DTOGCUP  
-DXF86BIGFONT    -DPIXPRIV -DPANORAMIX   -DRENDER -DRANDR   -DXFIXES -DDAMAGE
-DAVOID_GLYPHBLT -DPIXPRIV -DSINGLEDEPTH               -DXvExtension           
-DXFree86Server   -DXvMCExtension              -DSMART_SCHEDULE        
-DBUILDDEBUG -DXResExtension                -DX_BYTE_ORDER=X_BIG_ENDIAN     
-DXORG_VERSION_CURRENT="(((6) * 10000000) + ((7) * 100000) + ((0) * 1000) + 0)"
-DNDEBUG        -DXVENDORNAME='"The X.Org Foundation"'
-DXVENDORNAMESHORT='"X.Org"'  fbtrap.c
fbtrap.c: In function `PixelAlpha':
fbtrap.c:943: error: structure has no member named `p1'
fbtrap.c:944: error: structure has no member named `p1'
fbtrap.c:945: error: structure has no member named `p2'
fbtrap.c:946: error: structure has no member named `p2'
make[1]: *** [fbtrap.o] Error 1
make: *** [fb] Error 2
-- snip --

Another once caused by linking problems:
-- snip --
make[1]: Nothing to be done for `all'.
/usr/bin/cc -o Xprt -g -DDEBUG -DDEBUG_gisburn -Wall -Wpointer-arith
-no-cpp-precomp -UNEED_SCREEN_REGIONS     -L../../exports/lib   Xprint/ddxInit.o
Xprint/miinitext.o     dix/libdix.a os/libos.a  Xprint/libprinter.a      
Xprint/raster/libraster.a Xprint/pcl/libpcl.a Xprint/pcl-mono/libpcl.a
Xprint/ps/libps.a mfb/libmfb.a cfb32/libcfb32.a      cfb/libcfb.a mfb/libmfb.a
dix/libxpstubs.a mi/libmi.a Xext/libext.a xkb/libxkb.a                   
lbx/liblbx.a                   ../../lib/lbxutil/liblbxutil.a dbe/libdbe.a
record/librecord.a  XTrap/libxtrap.a  randr/librandr.a render/librender.a 
-L/usr/X11R6/lib    ../../lib/font/libXfont.a -lfreetype dix/libxpstubs.a 
-lz            -lXau -lXdmcp  
ld: can't locate file for: -lfreetype
make: *** [Xprt] Error 1
-- snip --
Comment 1 Adam Jackson 2004-08-03 20:48:07 UTC
Created attachment 565 [details] [review]
s/pointer/char */

presumably this code was written before void *... yikes.
Comment 2 Adam Jackson 2004-08-03 20:53:25 UTC
Created attachment 566 [details] [review]
orphaned code removal

since I don't see how to translate what that debug printf does into how a
PixelWalk is defined now, just delete it.
Comment 3 Kevin E. Martin 2004-08-08 19:13:49 UTC
I had many failures when building with -DDEBUG.
This is going to take a while to sort out.
Comment 4 Adam Jackson 2005-06-07 16:27:00 UTC
non-default build settings are not blockers.
Comment 5 Adam Jackson 2005-10-22 00:00:10 UTC
this particular bug is uninteresting, -DDEBUG is not expected to be a usable
flag in host.def for 6.9.  individual modules should still get cleaned up, and
feel free to track that progress in separate bugs.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.