|Summary:||piglit glsl-1.50 invariant-qualifier-in-out-block-01 regression|
|Product:||Mesa||Reporter:||Vinson Lee <vlee>|
|Status:||RESOLVED FIXED||QA Contact:||mesa-dev|
|Priority:||medium||CC:||huax.lu, idr, mattst88, siglesias|
|i915 platform:||i915 features:|
Description Vinson Lee 2015-02-26 02:35:39 UTC
Comment 1 Samuel Iglesias Gonsálvez 2015-02-26 07:04:28 UTC
We submitted a spec bug because it's not completely clear whether or not invariant should be allowed in an 'in' or 'out' block in GLSL or OES_shader_io_blocks extension specs. Once we have the answer, we will reply to this bug report. Thanks!
Comment 2 lu hua 2015-03-02 06:13:40 UTC
I also see this fail.
Comment 3 Ian Romanick 2016-02-10 22:33:19 UTC
Feedback from Khronos is that invariant should be allowed on block members. In this case "global scope" meant "not in a function and not in a structure." Future spec versions will clarify the use of "global scope" here and elsewhere.
Comment 4 Samuel Iglesias Gonsálvez 2016-02-11 07:33:07 UTC
(In reply to Ian Romanick from comment #3) > Feedback from Khronos is that invariant should be allowed on block members. > In this case "global scope" meant "not in a function and not in a > structure." Future spec versions will clarify the use of "global scope" > here and elsewhere. Thanks for the feedback. I sent a patch to the mailing list: https://lists.freedesktop.org/archives/mesa-dev/2016-February/107263.html
Comment 5 Timothy Arceri 2016-02-12 08:51:38 UTC
Should be fixed by: commit 61ceb36ead2e88cce4b4bac63793e94d343a3cc4 glsl: Allow invariant qualifer in block members in desktop OpenGL. Feedback from Khronos is that 'invariant' should be allowed on block members for desktop OpenGL. Fix piglit regression added by fe1e89a0: invariant-qualifier-in-out-block-01.vert v2: - Allow it for in/out blocks in OpenGL ES too, so when OES_shader_io_blocks is supported we don't need to do any change (Timothy) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89330 Signed-off-by: Samuel Iglesias Gonsálvez <firstname.lastname@example.org> Reviewed-by: Timothy Arceri <email@example.com>