Bug 85171

Summary:	Incorrect error returned when exec fails when spawning
Product:	dbus	Reporter:	Ross Lagerwall <rosslagerwall>
Component:	core	Assignee:	D-Bus Maintainers <dbus>
Status:	RESOLVED DUPLICATE	QA Contact:	D-Bus Maintainers <dbus>
Severity:	normal
Priority:	medium
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch

Description Ross Lagerwall 2014-10-18 12:17:46 UTC

Created attachment 108027 [details] [review]
patch

Explained in the commit message...

commit c87d1bc0dc449ace9c0e178f43586ebffeeb33f5
Author: Ross Lagerwall <rosslagerwall@gmail.com>
Date:   Sat Oct 18 13:13:00 2014 +0100

    Return exec errors correctly when spawning
    
    If an error happens when calling exec(), don't let the real errnum be
    overwritten by the babysitter's CHILD_EXIT status.
    
    Before, an exec error would show something like:
    Failed to execute program org.rossl.test: Success
    
    After:
    Failed to execute program org.rossl.test: No such file or directory

Comment 1 Simon McVittie 2014-10-20 10:40:14 UTC

I think this is the same bug for which I have a patch waiting for review on Bug #24821. Does that patch work for you? Does it look sensible?

Comment 2 Ross Lagerwall 2014-10-21 19:20:16 UTC

Yeah, your patch works for me. Both patches look sensible and similar enough.

*** This bug has been marked as a duplicate of bug 24821 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.