Bug 8490

Summary: Race condition in luit
Product: xorg Reporter: Søren Sandmann Pedersen <soren.sandmann>
Component: App/luitAssignee: Juliusz Chroboczek <jch>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: high CC: flammie, jch, kas, kcwu
Version: 7.1 (2006.05)   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 6666    
Attachments:
Description Flags
patch none

Description Søren Sandmann Pedersen 2006-10-02 12:42:42 UTC 
See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=1971651

Apparently luit can hang if the child runs before the parent gets around to
setting up the terminal. The patch I'll attach fixes this by make the child wait
on a pipe until the parent is done.

The hang is in tcsetattr() which seems dubious to me, so there may be an
underlying reason that should be investigated.
Comment 1 Søren Sandmann Pedersen 2006-10-02 12:44:09 UTC 
Created attachment 7234 [details] [review]
patch
Comment 2 Juliusz Chroboczek 2006-10-31 08:11:55 UTC 
*** Bug 2443 has been marked as a duplicate of this bug. ***
Comment 3 Juliusz Chroboczek 2006-10-31 08:14:30 UTC 
The patch attached to this bug 8490 cannot possibly get in; it's too ugly for
words.  The patch in bug 2443 looks okay to me.

Could anyone who can reproduce this please check whether the patch in bug 2443,
available from

  http://bugs.xfree86.org/attachment.cgi?id=1301

fixes this issue?

Thanks,

Juliusz
Comment 4 Juliusz Chroboczek 2006-10-31 08:16:41 UTC 
*** Bug 1400 has been marked as a duplicate of this bug. ***
Comment 5 Flammie Pirinen 2006-10-31 15:52:19 UTC 
I just got hit by the bug (on Gentoo system with luit-1.0.1 and Xorg-7.1) and it
seems from quick testing that patch given does fix the bug, or at least I'm
unable to reproduce it so far.
Comment 6 Juliusz Chroboczek 2006-11-05 14:44:30 UTC 
Thanks to all for your help. Juliusz.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.