| Summary: | when demarshalling an object method call fails, the error is weird | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Simon McVittie <smcv> |
| Component: | GLib | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED MOVED | QA Contact: | D-Bus Maintainers <dbus> |
| Severity: | normal | ||
| Priority: | medium | CC: | alban.crequy |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Add a regression test for fd.o #83530
gerror_to_dbus_error_message: add support for remaining members of DBusGError invoke_object_method: when demarshalling fails, use the right error |
||
|
Description
Simon McVittie
2014-09-15 14:59:44 UTC
Created attachment 106325 [details] [review] Add a regression test for fd.o #83530 --- You will notice that there is a #if 0...#else...#endif block for the InvalidSignature error that Alban added, because it isn't actually emitted correctly. Created attachment 106326 [details] [review] gerror_to_dbus_error_message: add support for remaining members of DBusGError Nobody updated this when we added these 15 new error codes. --- If anyone is in any doubt about dbus-glib's maintenance status... this has been missing since at least 2008, and before then, dbus-glib didn't even have a properly stable ABI for errors. Such quality. Created attachment 106327 [details] [review] invoke_object_method: when demarshalling fails, use the right error This replaces the inappropriate org.freedesktop.DBus.GLib.ErrorError with the intended error codes, affecting two tests. --- With this, the InvalidSignature error that Alban added is actually thrown, as intended. NoMemory doesn't seem great for "your variants are too recursive"... but whatever, it's been raising ErrorError all this time, NoMemory isn't really any worse. (In reply to comment #1) > Add a regression test for fd.o #83530 ... no, this is a regression test for fd.o #80557. I'll correct this when I push. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/dbus/dbus-glib/issues/1. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.