| Summary: | [swrast] piglit glsl-fs-uniform-bool-1 regression | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Vinson Lee <vlee> |
| Component: | Mesa core | Assignee: | mesa-dev |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | anuj.phogat, mattst88, pavel.ondracka |
| Version: | git | Keywords: | bisected, regression |
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
r300g hack
gallium fix swrast fix |
||
This commit also regressed about 20 tests for r300g driver. Some examples of failing tests: spec/glsl-1.10/execution/built-in-functions/fs-all-bvec3.shader_test spec/glsl-1.10/execution/built-in-functions/fs-not-bvec2.shader_test spec/glsl-1.10/execution/built-in-functions/fs-op-not-bool.shader_test spec/glsl-1.20/execution/uniform-initializer/fs-bool-set-by-API.shader_test glsl-1.10/execution/built-in-functions/vs-op-selection-bool-bvec3-bvec3.shader_test and more... Created attachment 105739 [details] [review] r300g hack Pavel, does this patch fix r300g? It's a hack, I just need to confirm whether it works. Created attachment 105742 [details] [review] gallium fix Scratch that. A new patch is attached. Could you please test it on r300g? Created attachment 105743 [details] [review] swrast fix Vinson, could you please test if this attached patch fixes classic swrast? Thanks. (In reply to comment #3) > Created attachment 105742 [details] [review] [review] > gallium fix > > Scratch that. A new patch is attached. Could you please test it on r300g? Yes, that fixes it. Fixed by patches d67db73458c8d66861b97675660289a955569 and 1a00f247512f22e58548053a99a706615a1786. Closing. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
mesa: 04895f5c601b240df547739da786b7c2b65bdd1e (master 10.3.0-devel) $ ./bin/shader_runner tests/shaders/glsl-fs-uniform-bool-1.shader_test -auto Probe color at (1,1) Expected: 0.000000 1.000000 0.000000 Observed: 1.000000 0.000000 0.000000 PIGLIT: {"result": "fail" } 6df0fd8fe9ccf5c927797897277343f068420a45 is the first bad commit commit 6df0fd8fe9ccf5c927797897277343f068420a45 Author: Matt Turner <mattst88@gmail.com> Date: Fri Aug 8 11:58:16 2014 -0700 mesa: Upload boolean uniforms using UniformBooleanTrue. Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com> :040000 040000 15acd6eba095cfb2dcb699134349f6ccc5a79484 16675d631f977bec6d671bd8dc577b5372d93d71 M src bisect run success