Bug 826

Summary: [PATCH] xorgconfig doesn't respect font installation outside PROJECTROOT
Product: xorg Reporter: Donnie Berkholz <dberkholz>
Component: App/xorgconfigAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: ajax
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
URL: http://bugs.gentoo.org/show_bug.cgi?id=54132
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 1690    
Attachments:
Description Flags
xorgconfig-fontdir-fixes.patch none

Description Donnie Berkholz 2004-07-06 02:39:27 UTC 
xorgconfig generates an xorg.conf with a bunch of /usr/X11R6/... font
directories even when fonts have been installed elsewhere. Following is a
somewhat hackish patch to fix this.
Comment 1 Donnie Berkholz 2004-07-06 02:39:52 UTC 
Created attachment 441 [details] [review]
xorgconfig-fontdir-fixes.patch
Comment 2 Donnie Berkholz 2004-07-06 03:16:48 UTC 
Credit to me.
Comment 3 Adam Jackson 2005-02-10 22:38:26 UTC 
applied, thanks.
Comment 4 Donnie Berkholz 2005-02-10 23:53:54 UTC 
ajax, what exactly did you commit?

I'm looking at anholt's tinderbox and it looks like the commit may have broken it:

cleaning in programs/Xserver/hw/xfree86/xf86config...
"Makefile", line 1089: Unassociated shell command "$(VENDOR_DEFINES)
$(KEYBOARD_DEFS) $(FONT_MODULE_DEFS)"
make: fatal errors encountered -- cannot continue
*** Error code 1

Stop in /usr/home/tb-xorg/tb-xorg/XMonolithic/xc/programs/Xserver/hw/xfree86.
*** Error code 1

Stop in /usr/home/tb-xorg/tb-xorg/XMonolithic/xc/programs/Xserver.
*** Error code 1

Stop in /usr/home/tb-xorg/tb-xorg/XMonolithic/xc/programs.
*** Error code 1

Stop in /usr/home/tb-xorg/tb-xorg/XMonolithic/xc.
*** Error code 1

Stop in /usr/home/tb-xorg/tb-xorg/XMonolithic/xc.
<--- TINDERBOX FINISHED (FAILURE: 256) RUNNING 'make World' Fri, 11 Feb 2005
07:39:35 GMT
Build failed with result 200
Comment 5 Donnie Berkholz 2005-02-11 00:09:36 UTC 
OK there's a missing backslash in the Imakefile:
http://cvs.freedesktop.org/xorg/xc/programs/Xserver/hw/xfree86/xf86config/Imakefile?r1=1.6&r2=1.7

 -DXFONTDIR=\"$(FONTDIR)\"
Comment 6 Adam Jackson 2005-02-11 05:42:26 UTC 
d'oh.  fixed, thanks.

that Imakefile stanza had been extended since the patch posted here so i had to
fill it in by hand.  i screwed up.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.