Bug 8037

Summary: Improve debugging messages in exchange_credentials
Product: dbus Reporter: Julio Merino <jmmv>
Component: coreAssignee: Havoc Pennington <hp>
Status: RESOLVED FIXED QA Contact: John (J5) Palmieri <johnp>
Severity: enhancement    
Priority: high Keywords: patch
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Proposed improvement.

Description Julio Merino 2006-08-27 14:59:11 UTC 
The exchange_credentials function calls a couple of functions from dbus-sysdeps
that do some work on the provided socket.  These functions are passed a NULL
value in the DBusError parameter, thus not reporting any error to the parent.

While working on the credentials code, I have found it very useful if these two
error messages were available as debugging messages when DBUS_VERBOSE is
enabled.  I've also added another verbose message at the beginning of the function.

I'm sending these here in case you find them useful too and can be added to the
tree.
Comment 1 Julio Merino 2006-08-27 14:59:28 UTC 
Created attachment 6726 [details] [review]
Proposed improvement.
Comment 2 John (J5) Palmieri 2006-10-13 14:14:51 UTC 
Committed with some changes.  The file is now dbus-transport-sockets.c and the
second dbus_error_init shouldn't be there. Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.