Bug 79361

Summary:	More clang/tartan fixes
Product:	Telepathy	Reporter:	Guillaume Desmottes <guillaume.desmottes>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=tartan
Whiteboard:
i915 platform:		i915 features:

Description Guillaume Desmottes 2014-05-28 10:48:18 UTC

Here are more fixes detected using clang and tartan: http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=tartan

Comment 1 Simon McVittie 2014-09-17 12:16:15 UTC

 static void
-test_notify_cb (Test *test,
+test_notify_cb (TpAccount *account,
     GParamSpec *pspec,
-    TpAccount *account)
+    Test *test)

The fact that you had to un-swap this seems like a bug in Tartan (Tartan should understand _swapped signal callbacks), but OK.

Comment 2 Simon McVittie 2014-09-17 12:22:45 UTC

Fixed in git for 0.99.12, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.