| Summary: | Xlib-based build broken on non x86/x86-64 architectures | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Andreas Boll <andreas.boll.dev> |
| Component: | Other | Assignee: | Ian Romanick <idr> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | idr |
| Version: | git | Keywords: | bisected, regression |
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 79039 | ||
| Attachments: | Full build log of mesa-10.2.0rc4-powerpc | ||
|
Description
Andreas Boll
2014-05-27 08:06:45 UTC
This issue seems to be related with Bug 79230 Feel free to close this as duplicate. This build issue is reproducible on x86/x86-64 architectures if --disable-asm is additionally added to ./configure There are 4 commits involved in this issue: f6e290f80cc6728647e9cee35546190f081197e2 is the first bad commit commit f6e290f80cc6728647e9cee35546190f081197e2 Author: Ian Romanick <ian.d.romanick@intel.com> Date: Wed Mar 26 15:25:08 2014 -0700 glapi/es1: Don't mark core functions as static_dispatch=false Functions that are part of OpenGL ES 1.0 or 1.1 should have static dispatch functions in libGLESv1_CM. This doesn't affect any change yet, but it will prevent later regressions. Signed-off-by: Ian Romanick <ian.d.romanick@intel.com> Reviewed-by: Matt Turner <mattst88@gmail.com> Acked-by: Chad Versace <chad.versace@linux.intel.com> This commit got reverted in: commit 526e49290cd2d83fb931708a786c27647972a00c Author: Brian Paul <brianp@vmware.com> Date: Tue Apr 1 07:39:36 2014 -0600 Revert "glapi/es1: Don't mark core functions as static_dispatch=false" This reverts commit f6e290f80cc6728647e9cee35546190f081197e2. To fix the broken build. The DRI-enabled build seems OK after reverting. Th non-DRI/gallium build is still suffering from an unrelated issue in the pipe-loader code. which fixed this build issue. Later this revert-commit got reverted, which introduced the build issue again: 65ca63043723d7dd23c204bd2cee4f6a2378ad8 is the first bad commit commit 065ca63043723d7dd23c204bd2cee4f6a2378ad8 Author: Ian Romanick <ian.d.romanick@intel.com> Date: Tue Apr 1 13:11:46 2014 -0700 Revert "Revert "glapi/es1: Don't mark core functions as static_dispatch=false"" This reverts commit 526e49290cd2d83fb931708a786c27647972a00c. The original build problem should be fixed by the previous commit. Signed-off-by: Ian Romanick <ian.d.romanick@intel.com> Tested-by: Brian Paul <brianp@vmware.com> Tested-by: Lu Hua <huax.lu@intel.com> And finally this commit introduced one more missing prototype: commit 5a68f731029258ddede4bd5d578cee203f4a80b3 Author: Ian Romanick <ian.d.romanick@intel.com> Date: Tue Apr 1 21:32:11 2014 -0700 glapi: Add static dispatch for glPointSizePointerOES The OpenGL ES 1.1 conformance tests expect this function to be statically available form libGLESv1_CM.so. The comment "required for es1.1" in the XML file should have been a clue. Signed-off-by: Ian Romanick <ian.d.romanick@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76926 Reviewed-by: Matt Turner <mattst88@gmail.com> Tested-by: Lu Hua <huax.lu@intel.com> I'll work on this today. Please, no more reverts. We know that will break es1. So... nobody else has encountered this before because they aren't building with -Werror=missing-prototypes. Why are you doing that? We should definitely fix this, but it's also not a blocker. Does this fix the various build problems? http://lists.freedesktop.org/archives/mesa-dev/2014-May/060454.html (In reply to comment #4) > So... nobody else has encountered this before because they aren't building > with -Werror=missing-prototypes. Why are you doing that? We should > definitely fix this, but it's also not a blocker. mesa upstream adds -Werror=missing-prototypes to CFLAGS [1] [1] http://cgit.freedesktop.org/mesa/mesa/tree/configure.ac#n183 (In reply to comment #5) > Does this fix the various build problems? > > http://lists.freedesktop.org/archives/mesa-dev/2014-May/060454.html Yes it does. Tested-by: Andreas Boll <andreas.boll.dev@gmail.com> (I've tested it on amd64 so far.) Thanks! Fixed with commit 7b1aeec9cd8c9b790d452eaf769ccbce51627908 Author: Ian Romanick <ian.d.romanick@intel.com> Date: Fri May 30 13:55:28 2014 -0700 glapi: Duplicate GLES1 prototypes in glapi_dispatch.c These prototypes are necessary because GLES1 library builds will create dispatch functions for them. We can't directly include GLES/gl.h because it would conflict the previously-included GL/gl.h. Since GLES1 ABI is not expected to every add more functions, the path of least resistance is to just duplicate the prototypes for the functions that aren't already in desktop OpenGL. Signed-off-by: Ian Romanick <ian.d.romanick@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79294 Acked-by: Matt Turner <mattst88@gmail.com> Tested-by: Andreas Boll <andreas.boll.dev@gmail.com> Cc: "10.2" <mesa-stable@lists.freedesktop.org> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.