Bug 78318

Summary:	[swrast] piglit glsl-kwin-blur-1 regression
Product:	Mesa	Reporter:	Vinson Lee <vlee>
Component:	Drivers/DRI/swrast	Assignee:	mesa-dev
Status:	RESOLVED MOVED	QA Contact:
Severity:	normal
Priority:	medium	CC:	idr, olvaffe
Version:	10.2	Keywords:	bisected, regression
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	79039

Description Vinson Lee 2014-05-06 00:07:47 UTC

mesa: 6dd907c80d3f9f17e24c751e5723e279fd70891b (master 10.3.0-devel)

$ ./bin/glsl-kwin-blur-1 -auto
Probe color at (50,18)
  Expected: 0.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,81)
  Expected: 0.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe color at (18,50)
  Expected: 0.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe color at (81,50)
  Expected: 0.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,19)
  Expected: 0.011765 0.011765 0.011765
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,80)
  Expected: 0.011765 0.011765 0.011765
  Observed: 1.000000 1.000000 1.000000
Probe color at (19,50)
  Expected: 0.011765 0.011765 0.011765
  Observed: 1.000000 1.000000 1.000000
Probe color at (80,50)
  Expected: 0.011765 0.011765 0.011765
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,20)
  Expected: 0.023529 0.023529 0.023529
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,79)
  Expected: 0.023529 0.023529 0.023529
  Observed: 1.000000 1.000000 1.000000
Probe color at (20,50)
  Expected: 0.023529 0.023529 0.023529
  Observed: 1.000000 1.000000 1.000000
Probe color at (79,50)
  Expected: 0.023529 0.023529 0.023529
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,21)
  Expected: 0.082353 0.082353 0.082353
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,78)
  Expected: 0.082353 0.082353 0.082353
  Observed: 1.000000 1.000000 1.000000
Probe color at (21,50)
  Expected: 0.082353 0.082353 0.082353
  Observed: 1.000000 1.000000 1.000000
Probe color at (78,50)
  Expected: 0.082353 0.082353 0.082353
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,22)
  Expected: 0.141176 0.141176 0.141176
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,77)
  Expected: 0.141176 0.141176 0.141176
  Observed: 1.000000 1.000000 1.000000
Probe color at (22,50)
  Expected: 0.141176 0.141176 0.141176
  Observed: 1.000000 1.000000 1.000000
Probe color at (77,50)
  Expected: 0.141176 0.141176 0.141176
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,23)
  Expected: 0.278431 0.278431 0.278431
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,76)
  Expected: 0.278431 0.278431 0.278431
  Observed: 1.000000 1.000000 1.000000
Probe color at (23,50)
  Expected: 0.278431 0.278431 0.278431
  Observed: 1.000000 1.000000 1.000000
Probe color at (76,50)
  Expected: 0.278431 0.278431 0.278431
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,24)
  Expected: 0.415686 0.415686 0.415686
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,75)
  Expected: 0.415686 0.415686 0.415686
  Observed: 1.000000 1.000000 1.000000
Probe color at (24,50)
  Expected: 0.415686 0.415686 0.415686
  Observed: 1.000000 1.000000 1.000000
Probe color at (75,50)
  Expected: 0.415686 0.415686 0.415686
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,25)
  Expected: 0.584314 0.584314 0.584314
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,74)
  Expected: 0.584314 0.584314 0.584314
  Observed: 1.000000 1.000000 1.000000
Probe color at (25,50)
  Expected: 0.584314 0.584314 0.584314
  Observed: 1.000000 1.000000 1.000000
Probe color at (74,50)
  Expected: 0.584314 0.584314 0.584314
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,26)
  Expected: 0.721569 0.721569 0.721569
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,73)
  Expected: 0.721569 0.721569 0.721569
  Observed: 1.000000 1.000000 1.000000
Probe color at (26,50)
  Expected: 0.721569 0.721569 0.721569
  Observed: 1.000000 1.000000 1.000000
Probe color at (73,50)
  Expected: 0.721569 0.721569 0.721569
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,27)
  Expected: 0.858824 0.858824 0.858824
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,72)
  Expected: 0.858824 0.858824 0.858824
  Observed: 1.000000 1.000000 1.000000
Probe color at (27,50)
  Expected: 0.858824 0.858824 0.858824
  Observed: 1.000000 1.000000 1.000000
Probe color at (72,50)
  Expected: 0.858824 0.858824 0.858824
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,28)
  Expected: 0.917647 0.917647 0.917647
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,71)
  Expected: 0.917647 0.917647 0.917647
  Observed: 1.000000 1.000000 1.000000
Probe color at (28,50)
  Expected: 0.917647 0.917647 0.917647
  Observed: 1.000000 1.000000 1.000000
Probe color at (71,50)
  Expected: 0.917647 0.917647 0.917647
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,29)
  Expected: 0.976471 0.976471 0.976471
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,70)
  Expected: 0.976471 0.976471 0.976471
  Observed: 1.000000 1.000000 1.000000
Probe color at (29,50)
  Expected: 0.976471 0.976471 0.976471
  Observed: 1.000000 1.000000 1.000000
Probe color at (70,50)
  Expected: 0.976471 0.976471 0.976471
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,30)
  Expected: 0.988235 0.988235 0.988235
  Observed: 1.000000 1.000000 1.000000
Probe color at (50,69)
  Expected: 0.988235 0.988235 0.988235
  Observed: 1.000000 1.000000 1.000000
Probe color at (30,50)
  Expected: 0.988235 0.988235 0.988235
  Observed: 1.000000 1.000000 1.000000
Probe color at (69,50)
  Expected: 0.988235 0.988235 0.988235
  Observed: 1.000000 1.000000 1.000000
Probe color at (20,20)
  Expected: 0.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe color at (20,79)
  Expected: 0.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe color at (79,20)
  Expected: 0.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe color at (79,79)
  Expected: 0.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe color at (21,21)
  Expected: 0.007843 0.007843 0.007843
  Observed: 1.000000 1.000000 1.000000
Probe color at (21,78)
  Expected: 0.007843 0.007843 0.007843
  Observed: 1.000000 1.000000 1.000000
Probe color at (78,21)
  Expected: 0.007843 0.007843 0.007843
  Observed: 1.000000 1.000000 1.000000
Probe color at (78,78)
  Expected: 0.007843 0.007843 0.007843
  Observed: 1.000000 1.000000 1.000000
Probe color at (22,22)
  Expected: 0.019608 0.019608 0.019608
  Observed: 1.000000 1.000000 1.000000
Probe color at (22,77)
  Expected: 0.019608 0.019608 0.019608
  Observed: 1.000000 1.000000 1.000000
Probe color at (77,22)
  Expected: 0.019608 0.019608 0.019608
  Observed: 1.000000 1.000000 1.000000
Probe color at (77,77)
  Expected: 0.019608 0.019608 0.019608
  Observed: 1.000000 1.000000 1.000000
Probe color at (23,23)
  Expected: 0.078431 0.078431 0.078431
  Observed: 1.000000 1.000000 1.000000
Probe color at (23,76)
  Expected: 0.078431 0.078431 0.078431
  Observed: 1.000000 1.000000 1.000000
Probe color at (76,23)
  Expected: 0.078431 0.078431 0.078431
  Observed: 1.000000 1.000000 1.000000
Probe color at (76,76)
  Expected: 0.078431 0.078431 0.078431
  Observed: 1.000000 1.000000 1.000000
Probe color at (24,24)
  Expected: 0.172549 0.172549 0.172549
  Observed: 1.000000 1.000000 1.000000
Probe color at (24,75)
  Expected: 0.172549 0.172549 0.172549
  Observed: 1.000000 1.000000 1.000000
Probe color at (75,24)
  Expected: 0.172549 0.172549 0.172549
  Observed: 1.000000 1.000000 1.000000
Probe color at (75,75)
  Expected: 0.172549 0.172549 0.172549
  Observed: 1.000000 1.000000 1.000000
Probe color at (25,25)
  Expected: 0.341176 0.341176 0.341176
  Observed: 1.000000 1.000000 1.000000
Probe color at (25,74)
  Expected: 0.341176 0.341176 0.341176
  Observed: 1.000000 1.000000 1.000000
Probe color at (74,25)
  Expected: 0.341176 0.341176 0.341176
  Observed: 1.000000 1.000000 1.000000
Probe color at (74,74)
  Expected: 0.341176 0.341176 0.341176
  Observed: 1.000000 1.000000 1.000000
Probe color at (26,26)
  Expected: 0.521569 0.521569 0.521569
  Observed: 1.000000 1.000000 1.000000
Probe color at (26,73)
  Expected: 0.521569 0.521569 0.521569
  Observed: 1.000000 1.000000 1.000000
Probe color at (73,26)
  Expected: 0.521569 0.521569 0.521569
  Observed: 1.000000 1.000000 1.000000
Probe color at (73,73)
  Expected: 0.521569 0.521569 0.521569
  Observed: 1.000000 1.000000 1.000000
Probe color at (27,27)
  Expected: 0.737255 0.737255 0.737255
  Observed: 1.000000 1.000000 1.000000
Probe color at (27,72)
  Expected: 0.737255 0.737255 0.737255
  Observed: 1.000000 1.000000 1.000000
Probe color at (72,27)
  Expected: 0.737255 0.737255 0.737255
  Observed: 1.000000 1.000000 1.000000
Probe color at (72,72)
  Expected: 0.737255 0.737255 0.737255
  Observed: 1.000000 1.000000 1.000000
Probe color at (28,28)
  Expected: 0.843137 0.843137 0.843137
  Observed: 1.000000 1.000000 1.000000
Probe color at (28,71)
  Expected: 0.843137 0.843137 0.843137
  Observed: 1.000000 1.000000 1.000000
Probe color at (71,28)
  Expected: 0.843137 0.843137 0.843137
  Observed: 1.000000 1.000000 1.000000
Probe color at (71,71)
  Expected: 0.843137 0.843137 0.843137
  Observed: 1.000000 1.000000 1.000000
Probe color at (29,29)
  Expected: 0.952941 0.952941 0.952941
  Observed: 1.000000 1.000000 1.000000
Probe color at (29,70)
  Expected: 0.952941 0.952941 0.952941
  Observed: 1.000000 1.000000 1.000000
Probe color at (70,29)
  Expected: 0.952941 0.952941 0.952941
  Observed: 1.000000 1.000000 1.000000
Probe color at (70,70)
  Expected: 0.952941 0.952941 0.952941
  Observed: 1.000000 1.000000 1.000000
Probe color at (30,30)
  Expected: 0.976471 0.976471 0.976471
  Observed: 1.000000 1.000000 1.000000
Probe color at (30,69)
  Expected: 0.976471 0.976471 0.976471
  Observed: 1.000000 1.000000 1.000000
Probe color at (69,30)
  Expected: 0.976471 0.976471 0.976471
  Observed: 1.000000 1.000000 1.000000
Probe color at (69,69)
  Expected: 0.976471 0.976471 0.976471
  Observed: 1.000000 1.000000 1.000000
PIGLIT: {'result': 'fail' }

# only skipped commits left to test
# possible first bad commit: [e608449d3e7dc86b90acfb31d9c948c57cf0e920] mesa/sso: Enable GL_ARB_separate_shader_objects by default
# possible first bad commit: [0939d3d0974a579fa65b76ebc6074d61e11f03b0] sso: Add display list support for ARB_separate_shader_objects new functions
# possible first bad commit: [7ff937e5793dc8709c916e043b41142033c8e69e] linker: Modify cross_validate_outputs_to_inputs to match using explicit locations
# possible first bad commit: [d030a3404ca0fedf365cb0fd41eaad7abc8ff132] linker: Sort shader I/O variables into a canonical order
# possible first bad commit: [c557eb77225433fa9415a94fc9db3ce36374df64] linker: Allow geometry shader without vertex shader for separable programs
# possible first bad commit: [1ff5a2b1ba2148b772f5e5c86d64c3cb18e1ce97] linker: Assign varying locations for separable programs
# possible first bad commit: [7d73c3e99ec14031e3834096f7e8e257338b64d4] linker: Allow consumer stage or producer stage to be NULL
# possible first bad commit: [fe37cb0ac67071759a88ea767027368399e1fdb6] linker: Refactor code that gets an input matching an output
# possible first bad commit: [5699220cd5719be6fbafdefd75025a817bcb200a] glsl: Exit when the shader IR contains an interface block instance
# possible first bad commit: [ba7195d126ce20bf74a27725224662aaca4d90ef] glsl/tests: Add first simple tests of populate_consumer_input_sets
# possible first bad commit: [8f5852bd2b91df7b259e5aeafb6a62a4268ca4c4] linker: Refactor code that builds hash tables of varyings during linking
# possible first bad commit: [ca21cffebd063354291d561eadc2ded8795a5333] meta: Fix saving the program pipeline state

Comment 1 Kenneth Graunke 2014-05-28 20:23:45 UTC

This is the first broken commit:

commit ca21cffebd063354291d561eadc2ded8795a5333
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Tue Mar 25 18:34:31 2014 -0700

    meta: Fix saving the program pipeline state
    
    This code was broken in some odd ways before.  Too much state was being
    saved, it was being restored in the wrong order, and in the wrong way.
    The biggest problem was that the pipeline object was restored before
    restoring the programs attached to the default pipeline.
    
    Fixes a regression in the glean texgen test.
    
    v3: Fairly significant re-write.  I think it's much cleaner now, and it
    avoids a bug with some meta ops that use shaders (reported by Chia-I).
    
    v4: Check Pipeline.Current against NULL instead of Pipeline.Default.
    Suggested by Chia-I.
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Reviewed-by: Chia-I Wu <olv@lunarg.com>

The test passes with the previous commit.  With this commit, Mesa fails to build due to a missing } in meta.c, but with that fixed, the test fails.

Comment 2 Vinson Lee 2014-09-12 22:45:18 UTC

mesa: d13d2fd16132f351ec7c8184f165faeac3b31bb4 (master 10.4.0-devel)

Regression is still present.

Comment 3 Chia-I Wu 2014-09-13 00:53:47 UTC

The test passes with the bisected commit here (after fixing the build error Kenneth mentioned)

$ glxinfo | grep git-
OpenGL core profile version string: 3.1 (Core Profile) Mesa 10.2.0-devel (git-ca21cff)
OpenGL version string: 3.0 Mesa 10.2.0-devel (git-ca21cff)
$ ./bin/glsl-kwin-blur-1 -auto
PIGLIT: {"result": "pass" }

It also passes with current master, using both i965 and softpipe.  I don't have a composited desktop environment.  Could that be the difference?

Comment 4 Vinson Lee 2015-02-14 02:19:16 UTC

mesa: 8323796840a343ee39687cc8e8b424ee43d6fee7 (master 10.6.0-devel)

piglit glsl-kwin-blur-1 regression is still present.

Comment 5 Vinson Lee 2015-06-21 04:02:03 UTC

mesa: 717376155d2082d7bf94122a1e1d383b39e0b070 (master 10.7.0-devel)

piglit glsl-kwin-blur-1 regression is still present.

Comment 6 Vinson Lee 2016-03-22 02:32:04 UTC

mesa: 1e8435ce0cce671024ebf9c5465ea8bdcb563b69 (master 11.3.0-devel)

piglit glsl-kwin-blur-1 regression is still present.

Comment 7 Vinson Lee 2017-03-31 23:36:52 UTC

mesa: 150736b5c34fc07de296454b973ae72ede215ae2 (master 17.1.0-devel)

piglit glsl-kwin-blur-1 regression is still present.

Comment 8 GitLab Migration User 2019-09-18 18:45:06 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/313.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.