Bug 76601

Summary:	[llvmpipe] [softpipe] piglit glean pixelFormats regression
Product:	Mesa	Reporter:	Vinson Lee <vlee>
Component:	Mesa core	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	brianp, chrisf
Version:	git	Keywords:	regression
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Vinson Lee 2014-03-25 17:26:44 UTC

mesa: b995a010e688bc4d4557e973e5e28091c378e881 (master 10.2.0-devel)

$ ./bin/glean -t pixelFormats --quick
pixelFormats failed at pixel (0,0), color channel 0:
  Expected: 0xff 0x00 0x00 0xff
  Found:    0xff 0xff 0xff 0xff
  Format: GL_RED
  Type: GL_UNSIGNED_SHORT
  Internal Format: glDrawPixels
  EnvMode: GL_COMBINE_ARB
pixelFormats:  FAIL rgba8, db, z24, s8, win+pmap, id 33
	21499 tests passed, 1 tests failed.

40d7b5195351d3e4199e7a840615a595a6dbaefc is the first bad commit
commit 40d7b5195351d3e4199e7a840615a595a6dbaefc
Author: Chris Forbes <chrisf@ijw.co.nz>
Date:   Sun Mar 23 22:07:02 2014 +1300

    mesa: Fix format matching checks for GL_INTENSITY* internalformats.
    
    GL_INTENSITY has never been valid as a pixel format -- to get the memcpy
    pack/unpack paths, the app needs to specify GL_RED as the pixel format
    (or GL_RED_INTEGER for the integer formats).
    
    Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
    Reviewed-by: Brian Paul <brianp@vmware.com>

:040000 040000 f6c61704eb29883f7f1f6b3ca0a0b33c3b37abfd cb5fa6fcaea7036f0792067e35567f9cc4147151 M	src
bisect run success

Comment 1 Chris Forbes 2014-03-31 20:00:49 UTC

Fix is now in master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.